Several strings are not localized in onboarding and autofill screens

[TheoChevalier]

Multiple strings are either hardcoded, haven’t been exposed to the xliff file, or are not used. Adding screenshots below

• “Deselect iCloud keychain” → Not exposed to Pontoon (explictly add "Deselect iCloud Keychain" strings to all locales #1032)
• “Firefox Lockbox will use Face ID to sign you in to the app” → Not exposed to Pontoon (Remove product name from strings #992)
• “Sync between devices with secure 256-bits encryption” → Exposed, but not used
• The headline in the instruction screen could use a line break, too (moved to Spinner constraint fixes for languages with longer strings #1027 Translated strings don't wrap on autofill instruction or item detail screens #1029 )

[TheoChevalier]

Morphing this bug to include additional missing strings:

[devinreams]

Thanks for the report @TheoChevalier. We'll look at this shortly...

[devinreams]

“Sync between devices with secure 256-bits encryption” → Exposed, but not used

@sashei I can't tell why this one may not be connecting up:

“Sync between devices with secure 256-bits encryption” → Exposed, but not used

Anything obvious jump out at you? I'll look more tomorrow

[sashei]

@devinreams we are doing manual interpolation to put the link in for 256-bit encryption. Looking at some languages, we expect the storyboard text to match exactly a different piece of text that's localized as Constant.string.onboardingSecurityPostfix. The string formatting is definitely failing because the strings (the one in the storyboard + the one in the generic Localizable.strings) don't line up. I think we need to tweak how we are getting that string interpolated + localized to work (although I'm not sure why it would fall back to English when the string formatting fails??).

All that to say, we need a bigger string change, which I think would be best addressed after l10n is shipped. For a quick fix, we could remove the string formatting (lines 60-77) in the OnboardingConfirmationVIew and ship the initial localized version without the explainer encryption link.

[sashei]

I've filed a new ticket for the encryption text issue: #1061