Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node JS version for the ML API Adapter #3425

Closed
25 tasks done
PaulGregoryBaker opened this issue Jul 31, 2023 · 2 comments
Closed
25 tasks done

Update Node JS version for the ML API Adapter #3425

PaulGregoryBaker opened this issue Jul 31, 2023 · 2 comments
Assignees
@mdebarros
Labels
core-dev-squad pi-22 story

Comments

@PaulGregoryBaker
Copy link

PaulGregoryBaker commented Jul 31, 2023 •
edited by mdebarros
Loading

Goal:

As a Mojaloop Maintainer

I want to upgrade ML-API-Adapter to use the latest NodeJS LTS version

so that the NodeJS runtime is fully supported

Acceptance Criteria:

  • ML-API-Adapter will use latest Node v18.x
  • CI Image Scan should pass after Nodejs upgrade to Node v18.x
  • CI Image Scan should select the Nodejs version from the project's nvmrc file
  • Upgrade dependencies to the latest version
  • Update the master branch to main
    • update main readme
    • update ci config

Complexity: Medium

Uncertainty: Medium

---

Tasks:

  • Upgrade NodeJS version for the following dependencies
    • central-services-health
    • central-services-metrics
    • central-services-shared
    • central-services-stream
    • event-sdk
  • Update all dependencies
  • Validate all existing Audit issues to see if they are still applicable (ref: audit-ci.jsonc)
  • Update project to the latest LTS Nodejs version run CI tests
  • Update CI workflow based on the latest fixes made to the SDK-Scheme-Adapter CI workflow for NVM, etc. [@mdebarros]
  • Alignment to latest SDK repo updates (ref)
    • Add build-local after setup to optimise the build pipeline

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@mdebarros mdebarros self-assigned this Aug 2, 2023
@mdebarros mdebarros removed their assignment Aug 11, 2023
@JaneS321
Copy link

Refer to story 3386

@mdebarros
Copy link
Member

Reference PR for SDK-Scheme-Adapter as done as part of #3386 --> mojaloop/sdk-scheme-adapter#453

@mdebarros mdebarros mentioned this issue Aug 30, 2023
Merged
mdebarros added a commit to mojaloop/ml-api-adapter that referenced this issue Sep 4, 2023
@mdebarros
chore(majaloop/#3425): update node version (#513)
7b2ac92 
chore(majaloop/#3425): update node version - mojaloop/project#3425
- Updated docker-compose to use the local docker image
- Updated CI to include latest NVM improvements and main branch rename changes
- Aligned CI config
- Updated audit issues
- Upgraded node version to LTS
- Upgraded deps
- Refactored functional tests to use the ml-core-test-harness, and removed old unmaintained functional test suite
- Migrated master -> main
- Cleaned up package.json scripts, updated `docker:build`
- Re-aligned test scripts - `test:unit`, `test:xunit`, `test:unit:spec`, `test:int`, `test:xint`, `test-functional`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
core-dev-squad pi-22 story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oderayi @mdebarros @PaulGregoryBaker @JaneS321