Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(majaloop/#3425): update node version #513

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Aug 30, 2023

chore(majaloop/#3425): update node version - mojaloop/project#3425

  • Updated docker-compose to use the local docker image
  • Updated CI to include latest NVM improvements and main branch rename changes
  • Aligned CI config
  • Updated audit issues
  • Upgraded node version to LTS
  • Upgraded deps
  • Refactored functional tests to use the ml-core-test-harness, and removed old unmaintained functional test suite
  • Migrated master -> main
  • Cleaned up package.json scripts, updated docker:build
  • Re-aligned test scripts - test:unit, test:xunit, test:unit:spec, test:int, test:xint, test-functional

@mdebarros mdebarros self-assigned this Aug 30, 2023
@kleyow
Copy link
Contributor

kleyow commented Sep 3, 2023

lgtm. are we going do major version bumps for the services?

@mdebarros
Copy link
Member Author

mdebarros commented Sep 4, 2023

lgtm. are we going do major version bumps for the services?

I don't think it's necessary for this, but I do think we may want to consider doing so for the msg key changes that you have on your PR.

oderayi
oderayi previously approved these changes Sep 4, 2023
@mdebarros mdebarros merged commit 7b2ac92 into mojaloop:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants