Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK] NodeJS Maintenance Upgrade for SDK-Scheme-Adapter #3386

Closed
15 tasks done
mdebarros opened this issue Jun 19, 2023 · 1 comment
Closed
15 tasks done

[SDK] NodeJS Maintenance Upgrade for SDK-Scheme-Adapter #3386

mdebarros opened this issue Jun 19, 2023 · 1 comment
Assignees
@mdebarros
Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it pi-21 Issues prioritized for Program Increment 21 pi-22 story

Comments

@mdebarros
Copy link
Member

mdebarros commented Jun 19, 2023 •
edited
Loading

Goal:

As a Mojaloop Maintainer

I want to have the SDK-Scheme-Adapter using the latest NodeJS LTS version

so that the NodeJS runtime is fully supported

Acceptance Criteria:

  • SDK-Scheme-Adapter will use latest Node v18.x
  • CI Image Scan should pass after Nodejs upgrade to Node v18.x
  • CI Image Scan should select the Nodejs version from the project's nvmrc file
  • Upgrade dependencies to the latest version

Complexity: Medium

Uncertainty: Medium

Tasks:

  • Upgrade Nodejs version
  • Upgrade dependencies to latest version
  • Resolve CI Image Scan pipeline failure
  • Change CI Image Scan to use Nodejs version from nvmrc file
  • Cleanup of Audit CI manifest

Done

  • Acceptance Criteria pass
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@mdebarros mdebarros added core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story to-be-refined This story is ready to be groomed labels Jun 19, 2023
@PaulGregoryBaker PaulGregoryBaker removed the to-be-refined This story is ready to be groomed label Jun 19, 2023
@mdebarros mdebarros self-assigned this Jun 19, 2023
@mdebarros mdebarros added the pi-21 Issues prioritized for Program Increment 21 label Jun 23, 2023
@mdebarros mdebarros changed the title [SDK] CI Image Scan on SDK-Scheme-Adapter is failing after nodeJs upgrade [SDK] NodeJS Maintenance Upgrade for SDK-Scheme-Adapter Jul 6, 2023
@mdebarros mdebarros added the pi-22 label Jul 6, 2023
@mdebarros mdebarros mentioned this issue Jul 6, 2023
Merged
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jul 10, 2023
@mdebarros
chore(mojaloop/#3386): sdk nodejs maintenance upgrade (#453)
9ac931a 
chore(mojaloop/#3386): sdk nodejs maintenance upgrade - mojaloop/project#3386
- Upgraded nodejs from v16 to latest v18 LTS
- Fixed CI pipeline to use NVM to select the Nodejs version from the Projects NVMRC file
- Fixed configs for NVM to install the correct Nodejs version on Alpine based CI Jobs
- Fixes to Image Scan to correctly select the correctly Nodejs Docker image for scanning
- Build-local now passes the NODE_VERSION (value from NVMRC file) as a Build-Arg to Docker Build command
- Changed Docker NODE_VERSION to LTS, and added NOTEs in Dockerfile and Documentation to main README on how to correctly set the BUILD-ARG
@mdebarros mdebarros mentioned this issue Jul 10, 2023
Merged
mdebarros added a commit to mojaloop/sdk-scheme-adapter that referenced this issue Jul 10, 2023
@mdebarros
fix: protobuff vuln issue (#455)
fa600ad 
Follow-up to chore(mojaloop/[#3386](https://github.com/kleyow/sdk-scheme-adapter/issues/3386)): sdk nodejs maintenance upgrade - mojaloop/project#3386
- fix: updated to audit-ci 
    - added protobuff vuln
    - cleaned up vuln that are no longer an issue
- chore: updated deps
@mdebarros
Copy link
Member Author

Screenshot 2023-07-10 at 14 06 43

@JaneS321 JaneS321 mentioned this issue Aug 14, 2023
Closed
25 tasks
@mdebarros mdebarros mentioned this issue Sep 4, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdebarros mdebarros

Labels
core-dev-squad oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it pi-21 Issues prioritized for Program Increment 21 pi-22 story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdebarros @PaulGregoryBaker