Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make color picker to follow cursor horizontally Fixes #34205 #41130

Closed
wants to merge 1 commit into from
Closed

Make color picker to follow cursor horizontally Fixes #34205 #41130

wants to merge 1 commit into from

Conversation

usernamehw
Copy link
Contributor

@rebornix rebornix added this to the February 2018 milestone Jan 30, 2018
@rebornix rebornix added the editor-color-picker Editor color picker widget issues label Jan 30, 2018
@usernamehw
Copy link
Contributor Author

@rebornix ping

@rebornix
Copy link
Member

@usernamehw I'm sure that using msg.range.startColumn can fix this particular problem but it may lead to another existing issue, which is Hover will disappear if part of it is outside the editor. We would probably need the same optimization for Suggest Widget (smart position) but it needs careful thoughts.

@usernamehw
Copy link
Contributor Author

usernamehw commented Feb 24, 2018 •
edited
Loading

That sounds like a separate issue. #36195 this one, I guess.

@bpasero bpasero modified the milestones: February 2018, March 2018 Mar 8, 2018
@bpasero bpasero modified the milestones: March 2018, April 2018 Apr 6, 2018
@bpasero bpasero modified the milestones: April 2018, May 2018 May 8, 2018
@usernamehw usernamehw closed this May 24, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rebornix rebornix

Labels
editor-color-picker Editor color picker widget issues
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@usernamehw @rebornix @bpasero