Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour picker disappears when mouse hovers outside editor split #36195

Closed
kimbar opened this issue Oct 13, 2017 · 4 comments
Closed

Colour picker disappears when mouse hovers outside editor split #36195

kimbar opened this issue Oct 13, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-color-picker Editor color picker widget issues editor-hover Editor mouse hover

Comments

@kimbar
Copy link

kimbar commented Oct 13, 2017

  • VSCode Version: Code 1.17.1 (1e9d365, 2017-10-10T14:24:41.632Z)
  • OS Version: Windows_NT ia32 6.1.7601

Steps to Reproduce:

  1. split the editor
  2. open "User Settings" in left split
  3. enter some custom colours in workbench.colorCustomizations
  4. shrink the left split enough to have a colour box near to the split edge
  5. activate colour picker
  6. move the pointer hovering over the colour picker, but through the split vertical line to the other side (eg. to change the hue)
  7. the colour picker disappears

obraz

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the workbench label Oct 13, 2017
@kimbar kimbar changed the title Colour picker disapears when mouse hovers outside editor split Colour picker disappears when mouse hovers outside editor split Oct 13, 2017
@isidorn isidorn assigned joaomoreno and unassigned isidorn Oct 13, 2017
@joaomoreno joaomoreno assigned rebornix and unassigned joaomoreno Oct 16, 2017
@alexdima alexdima added the editor-color-picker Editor color picker widget issues label Oct 26, 2017
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Nov 16, 2017
@kieferrm
Copy link
Member

kieferrm commented Dec 6, 2017

Since I have the sidebar on the right I hit that quite frequently.

@tommai78101
Copy link

tommai78101 commented Jun 21, 2018

My theory (may be wrong) is:


Each tab, regardless if it's a document, a settings, UI element, panel, etc., are considered as a JavaScript entity, document. When a mouse leaves a document, the event is fired off and no longer can be able to detect mouse events.

Perhaps the Color Picker is closing prematurely is because it received a mouseout event, a blur event, or something that would cause it to fire off a "close" event of some kind, because the document is telling the Color Picker the mouse has left the area.

This suggests that this is working as intended, and it's a by-product or side effect of how JavaScript works with document DOM Elements in VS Code.


Thoughts?

@rebornix
Copy link
Member

Shares the same root cause as #51794 since we are using the Hover for the color picker. Let's track it there.

@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 20, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 20, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 20, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-color-picker Editor color picker widget issues editor-hover Editor mouse hover
Projects
None yet
Development

No branches or pull requests

7 participants