Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Picker does not follow the cursor. #34205

Closed
hua03 opened this issue Sep 12, 2017 · 3 comments
Closed

Color Picker does not follow the cursor. #34205

hua03 opened this issue Sep 12, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover verified Verification succeeded

Comments

@hua03
Copy link

hua03 commented Sep 12, 2017

  • VSCode Version: 1.16.0
  • OS Version: Window10

Steps to Reproduce:

  1. open your VS Code.
  2. new a CSS file.
  3. paste this to you file
.wrap {
  display: inline-block;
  width: 300px;
  height: 300px;
  margin: 20px;
  background: repeating-linear-gradient(45deg, red, red 10px, orange 10px,orange 20px);
}
  1. Put your cursor over here orange

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the editor label Sep 12, 2017
@hua03 hua03 changed the title color picker does not follow the cursor. Color Picker does not follow the cursor. Sep 12, 2017
@alexdima
Copy link
Member

Hm, the hover computed by the CSS hover provider returns a range that encompasses the entire line. i.e. the range for the descriptive text "Shorthand property for setting most background properties at the same place in the style sheet" is the entire line. The hover then tries to position itself in such a way that it covers this range.

While this might make sense for the regular hover message, perhaps this does not make sense when also displaying the color picker in the hover message...

@ajitid
Copy link
Contributor

ajitid commented Sep 14, 2017

I still didn't had no problem even if color picker was shown at start of the line, but if you try to reach to the picker it hides itself

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover labels Sep 28, 2017
@alexdima alexdima added this to the Backlog milestone Sep 28, 2017
@iainhallam
Copy link

When this happens, it also means that simply by moving the mouse to the picker, you leave the colour, so it disappears! I think it either needs to move closer to the colour definition, or stay around a bit longer to allow a path to the picker that traverses the rest of the document without hiding the picker.

@alexdima alexdima removed the editor label Apr 17, 2018
@alexdima alexdima modified the milestones: Backlog, September 2018 Sep 20, 2018
@jrieken jrieken added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants