[zeroc-ice] New port #23764

bold84 · 2022-03-25T06:19:37Z

Describe the pull request

What does your PR fix?

Fixes ZeroC Ice Support #6106
Which triplets are supported/not supported? Have you updated the CI baseline?

windows, yes (still working on linux / mac)
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for zeroc-ice but no changes to version or port version.
-- Version: 3.7.7
-- Old SHA: 38305b2ef3fe0742978b9b6bc101afb1f6141161
-- New SHA: 99a4c4aefadf9f4110fc0e7ce769d71eaf48d7f8
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

…ping.

added entries to ci.baseline.txt

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for zeroc-ice but no changes to version or port version.
-- Version: 3.7.7
-- Old SHA: b0871b1fa5b10cdb71df1b110de4d7ca0dc0cc57
-- New SHA: 4cecb516e83aba9fb9c56153b7fa1f7040143aae
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for zeroc-ice but no changes to version or port version.
-- Version: 3.7.7
-- Old SHA: b0871b1fa5b10cdb71df1b110de4d7ca0dc0cc57
-- New SHA: 4cecb516e83aba9fb9c56153b7fa1f7040143aae
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

bold84 · 2022-03-25T07:25:20Z

The build succeeds, but this is an issue I'm not sure how to resolve in a way that's accepted here.

Ice requires the usage of an IDL file compiler, which I download in the powershell script before the build starts.

vcpkg_install_msbuild() doesn't let me remove these files before "installing" the binaries to the package folder.
I could use vcpkg_execute_build_process() instead of vcpkg_install_msbuild() but I'm not sure if that's okay for you guys.

As you can see in the portfile, I actually delete the fils from the packages directory.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for zeroc-ice but no changes to version or port version.
-- Version: 3.7.7
-- Old SHA: 4cecb516e83aba9fb9c56153b7fa1f7040143aae
-- New SHA: 37beab9f818399c78da3afe9f1bcf49ad706136a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

LilyWangLL · 2022-03-25T08:26:02Z

Now the pipeline error is The folder /include is empty or not present. This indicates the library was not correctly installed. the header file install incorrect.

LilyWangLL · 2022-03-25T09:39:04Z

zeroc-ice:x64-windows-static build failed on pipeline with the following error:

-- Installing: D:/packages/zeroc-ice_x64-windows-static/share/zeroc-ice/copyright
-- Performing post-build validation
Invalid crt linkage. Expected Debug,Static, but the following libs had:

    D:\packages\zeroc-ice_x64-windows-static\debug\lib\iceutild.lib: Debug,Dynamic
    D:\packages\zeroc-ice_x64-windows-static\debug\lib\sliced.lib: Debug,Dynamic

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Invalid crt linkage. Expected Release,Static, but the following libs had:

    D:\packages\zeroc-ice_x64-windows-static\lib\iceutil.lib: Release,Dynamic
    D:\packages\zeroc-ice_x64-windows-static\lib\slice.lib: Release,Dynamic

To inspect the lib files, use:
    dumpbin.exe /directives mylibfile.lib
Found 2 post-build check problem(s). To submit these ports to curated catalogs, please first correct the portfile:
    C:\a\1\s\ports\zeroc-ice\portfile.cmake

ghost · 2022-03-25T11:18:13Z

If I recall correctly, the CRT linkage was the reason why I opted to integrate CMake into Ice. There are also slice files that need to be available for the FindIce() feature to work correctly and I don't recall if the MSBuild recipe worked with that. I recall the cleanup in vcpkg will delete some binary files.

bold84 · 2022-03-25T11:26:59Z

If I recall correctly, the CRT linkage was the reason why I opted to integrate CMake into Ice. There are also slice files that need to be available for the FindIce() feature to work correctly and I don't recall if the MSBuild recipe worked with that. I recall the cleanup in vcpkg will delete some binary files.

I removed the hard coded crt linkage from the project files.

But good point, I need to add the slice files to the installation procedure. But I first have to get Linux and Mac working properly.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for zeroc-ice but no changes to version or port version.
-- Version: 3.7.7
-- Old SHA: 4f02050efcce648670e93d0b61888170d682c79b
-- New SHA: 0e4844d7863cb54220f9559c4388c7d023a603b7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

bold84 · 2022-03-31T09:31:30Z

Done.

I apologize for abusing the PR by pushing to this branch many times. I used this branch to transfer changes between different operating systems and architectures. In the future I would use a separate branch for this purpose. 😁

The port should build for Linux(x86,x64,arm,arm64), MacOS (x86,x64,arm64) and Windows (x86,x64), in shared and static build configurations. ZeroC's VS project files do not have configurations for arm and it would need a bit of work to make this work, because the slice compiler has to be built for the host machine as it's needed during the build of the subsequent components.

I will add Android, iOS and possibly Webassembly in separate PRs in the near future. The latter needs some work on Ice itself though.

bold84 · 2022-03-31T16:16:52Z

Why does it take so long for the commits to be built? Is there some kind of throttling?

dg0yt · 2022-03-31T16:39:10Z

Why does it take so long for the commits to be built? Is there some kind of throttling?

No, it is congestion.

Recent baseline regressions caused a backlog.
A broken tool/CI interaction causes PR CI runs to build ports which are known to fail.
The recent zlib update invalidated a lot of cached artifacts.
Some of the queued PRs need a lot of build time.
At least one port with significant build time fails to upload to cache.

Take a look at the queue:
https://dev.azure.com/vcpkg/public/_build?definitionId=27&_a=summary

bold84 · 2022-03-31T17:23:43Z

Why does it take so long for the commits to be built? Is there some kind of throttling?

No, it is congestion.

Recent baseline regressions caused a backlog.

A broken tool/CI interaction causes PR CI runs to build ports which are known to fail.

The recent zlib update invalidated a lot of cached artifacts.

Some of the queued PRs need a lot of build time.

At least one port with significant build time fails to upload to cache.

Take a look at the queue: https://dev.azure.com/vcpkg/public/_build?definitionId=27&_a=summary

Thank you for the explanation. 😊

LilyWangLL · 2022-04-02T07:35:16Z

@strega-nil-ms Could you please review this PR again?

bold84 · 2022-04-09T17:08:09Z

How many weeks does it typically take until you guys review change requests? ☺️

LilyWangLL · 2022-04-11T08:25:05Z

Ping @strega-nil

strega-nil-ms

merging once green!

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for zeroc-ice but no changes to version or port version.
-- Version: 3.7.7
-- Old SHA: 7b7a2836ffa07e08a43a7aa58b8de996d3902751
-- New SHA: bdb180069d461c04c1eee1a7937afa63d0ea752b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ghost · 2022-04-13T20:22:54Z

Done.

I apologize for abusing the PR by pushing to this branch many times. I used this branch to transfer changes between different operating systems and architectures. In the future I would use a separate branch for this purpose. grin

The port should build for Linux(x86,x64,arm,arm64), MacOS (x86,x64,arm64) and Windows (x86,x64), in shared and static build configurations. ZeroC's VS project files do not have configurations for arm and it would need a bit of work to make this work, because the slice compiler has to be built for the host machine as it's needed during the build of the subsequent components.

I will add Android, iOS and possibly Webassembly in separate PRs in the near future. The latter needs some work on Ice itself though.

Perhaps these will help with icebuilder and arm:
mumble-voip/ice@a9d68a8
https://github.com/mumble-voip/ice/blob/3.7/icebuilder/CMakeLists.txt

bold84 · 2022-04-13T20:26:09Z

@ZeroAbility Thanks!

At the moment re-doing the skia port. I will look into this later.

bold84 added 3 commits March 24, 2022 23:04

Initial commit

89aa4ab

clean up

0833b30

updated manifest and version

4912e18

github-actions bot requested changes Mar 25, 2022

View reviewed changes

bold84 added 2 commits March 24, 2022 23:35

Removed C++11 mapping option (feature) and made C++11 the default map…

a5b61cb

…ping.

updated version

897bbff

bold84 changed the title ~~[zeroc-ice] Initial commit~~ [zeroc-ice] New port Mar 25, 2022

github-actions bot approved these changes Mar 25, 2022

View reviewed changes

bold84 added 2 commits March 25, 2022 00:14

added main target

39c27d0

added entries to ci.baseline.txt

corrected ci.baseline.txt entries

b031d7e

github-actions bot requested changes Mar 25, 2022

View reviewed changes

updated version

45efd8c

github-actions bot approved these changes Mar 25, 2022

View reviewed changes

JonLiu1993 assigned LilyWangLL Mar 25, 2022

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 25, 2022

fixed generated header path

6963f50

github-actions bot requested changes Mar 25, 2022

View reviewed changes

Updated version

6c72220

github-actions bot approved these changes Mar 25, 2022

View reviewed changes

bold84 added 2 commits March 25, 2022 02:16

fixed include paths

c659211

updated version

75c052d

github-actions bot approved these changes Mar 25, 2022

View reviewed changes

expect x64-windows-static to fail

f60f20c

bold84 marked this pull request as ready for review March 25, 2022 10:47

github-actions bot requested changes Mar 31, 2022

View reviewed changes

updated version

f2ac64a

github-actions bot approved these changes Mar 31, 2022

View reviewed changes

bold84 added 3 commits March 31, 2022 10:40

windows-static

facd40f

allow static builds on windows and added maintainer

9829f9d

updated version

2881e55

github-actions bot approved these changes Mar 31, 2022

View reviewed changes

bold84 added 2 commits March 31, 2022 17:30

added openssl as a dependency for Ice core library

8da6d02

updated version

daab983

github-actions bot approved these changes Mar 31, 2022

View reviewed changes

LilyWangLL removed the requires:author-response label Apr 1, 2022

LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 12, 2022

minor updates

a4a58ae

strega-nil-ms force-pushed the zeroc_ice_port branch from a5aacb7 to a4a58ae Compare April 12, 2022 18:37

strega-nil-ms approved these changes Apr 12, 2022

View reviewed changes

github-actions bot requested changes Apr 12, 2022

View reviewed changes

github-actions bot approved these changes Apr 12, 2022

View reviewed changes

strega-nil-ms merged commit 1c9b23b into microsoft:master Apr 13, 2022

ghost mentioned this pull request Apr 13, 2022

Dependency scripts may have issues after merge of ZeroC Ice port to vcpkg mumble-voip/mumble#5624

Closed

BillyONeal mentioned this pull request Apr 15, 2022

Update VMs for April Patch Tuesday #24131

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[zeroc-ice] New port #23764

[zeroc-ice] New port #23764

bold84 commented Mar 25, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

bold84 commented Mar 25, 2022 •

edited

Loading

github-actions bot left a comment

LilyWangLL commented Mar 25, 2022

LilyWangLL commented Mar 25, 2022

ghost commented Mar 25, 2022

bold84 commented Mar 25, 2022

github-actions bot left a comment

bold84 commented Mar 31, 2022

bold84 commented Mar 31, 2022 •

edited

Loading

dg0yt commented Mar 31, 2022 •

edited

Loading

bold84 commented Mar 31, 2022

LilyWangLL commented Apr 2, 2022

bold84 commented Apr 9, 2022

LilyWangLL commented Apr 11, 2022

strega-nil-ms left a comment

github-actions bot left a comment

ghost commented Apr 13, 2022

bold84 commented Apr 13, 2022

[zeroc-ice] New port #23764

[zeroc-ice] New port #23764

Conversation

bold84 commented Mar 25, 2022 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

bold84 commented Mar 25, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

LilyWangLL commented Mar 25, 2022

LilyWangLL commented Mar 25, 2022

ghost commented Mar 25, 2022

bold84 commented Mar 25, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

bold84 commented Mar 31, 2022

bold84 commented Mar 31, 2022 • edited Loading

dg0yt commented Mar 31, 2022 • edited Loading

bold84 commented Mar 31, 2022

LilyWangLL commented Apr 2, 2022

bold84 commented Apr 9, 2022

LilyWangLL commented Apr 11, 2022

strega-nil-ms left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

ghost commented Apr 13, 2022

bold84 commented Apr 13, 2022

bold84 commented Mar 25, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

bold84 commented Mar 25, 2022 •

edited

Loading

bold84 commented Mar 31, 2022 •

edited

Loading

dg0yt commented Mar 31, 2022 •

edited

Loading