Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VMs for April Patch Tuesday #24131

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Update VMs for April Patch Tuesday #24131

merged 3 commits into from
Apr 15, 2022

Conversation

BillyONeal
Copy link
Member

Should also fix #23756

@BillyONeal
Update VM base tools:
909c842 
* Intel OneAPI updated
* Powershell Updated
* VS updated to install current Windows SDKs, and atlmfc for arm, and CMake/ninja
@BillyONeal
Update pools.
aa9cc02
@BillyONeal BillyONeal added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Apr 13, 2022
@Neumann-A
Copy link
Contributor

does the oneapi installation now set the required env vars ?

@BillyONeal
Copy link
Member Author

I hope so? I have no idea.

@BillyONeal
Copy link
Member Author

does the oneapi installation now set the required env vars ?

What ones do you want me to check for?

@Neumann-A
Copy link
Contributor

https://github.com/microsoft/vcpkg-tool/blob/7b2fc58f4ae3f03bf04fa83241db51ed285975c7/src/vcpkg/base/system.process.cpp#L356-L359

maybe also IFORT_COMPILER22 (don't know if the number actually stands for a year). One of the IFORT_COMPILER need to be set

@BillyONeal
Copy link
Member Author

https://github.com/microsoft/vcpkg-tool/blob/7b2fc58f4ae3f03bf04fa83241db51ed285975c7/src/vcpkg/base/system.process.cpp#L356-L359

maybe also IFORT_COMPILER22 (don't know if the number actually stands for a year). One of the IFORT_COMPILER need to be set

image

Maybe that works?

@JackBoosY JackBoosY self-assigned this Apr 14, 2022
@BillyONeal
Copy link
Member Author

PASSING, REMOVE FROM FAIL LIST: azure-storage-cpp:arm64-windows

Fixed by atlmfc being completely installed for those platforms. /cc @dg0yt

REGRESSION: dxsdk-d3dx:x64-windows-static-md failed with BUILD_FAILED

Should be fixed by 2437383

REGRESSION: zeroc-ice:x64-linux failed with BUILD_FAILED
REGRESSION: zeroc-ice:x64-windows-static failed with BUILD_FAILED

Probably broken by #23764 ?

@BillyONeal
Copy link
Member Author

Nicole confirmed with me over the shoulder that she was OK with this.

@strega-nil-ms
Copy link
Contributor

REGRESSION: zeroc-ice:x64-linux failed with BUILD_FAILED
REGRESSION: zeroc-ice:x64-windows-static failed with BUILD_FAILED

should be fixed by #24169

@BillyONeal BillyONeal merged commit aebb363 into microsoft:master Apr 15, 2022
@BillyONeal BillyONeal deleted the vm-update branch April 15, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vcpkg build fleet should have CMake, Ninja, and Python installed so they need not be vcpkg fetch'd every time
4 participants
@BillyONeal @Neumann-A @strega-nil-ms @JackBoosY