Dependency scripts may have issues after merge of ZeroC Ice port to vcpkg

[ghost]

Description

A ZeroC Ice port was recently merged to vcpkg:

microsoft/vcpkg#23764

By default, it builds with C++11 support and does not appear to have a feature/option to build using the C++98 project types. Our script for Windows checks for the presence of the folder zeroc-ice and if it does not exist it copies our custom port files to a new directory with that name. We need to move the vcpkg port folder in vcpkg/ports to something like vcpkg/ports/zeroc-ice_msbuild so we can add our custom port.

Steps to reproduce

1. Run the script in mumble/scripts/vcpkg to install vcpkg and dependency packages.
2. zeroc-ice package installs and produces a C++11 ice library which our project does not support.

Mumble version

No response

Mumble component

Server

OS

Windows

Reproducible?

Yes

Additional information

Will most likely affect macOS and Linux, possibly CI

Relevant log output

No response

Screenshots

No response

[ghost]

The pertinent script sections are here:

mumble/scripts/vcpkg/get_mumble_dependencies.ps1

Lines 62 to 65 in 0c2e398

	if (-not (Test-Path $vcpkgdir/ports/zeroc-ice)) {
	Write-Host "Adding ports for ZeroC Ice..."
	Copy-Item -Path $PSScriptRoot/../../helpers/vcpkg/ports/zeroc-ice -Destination $vcpkgdir/ports -Recurse
	}

mumble/scripts/vcpkg/get_mumble_dependencies.sh

Lines 76 to 77 in 0c2e398

	# copy ZeroC Ice port files
	cp -R helpers/vcpkg/ports/zeroc-ice $VCPKGDIR/ports

My recommendation would be to change the name of the directory to helpers/vcpkg/ports/zeroc-ice-mumble and update the scripts accordingly.

[Krzmbrzl]

My recommendation would be to change the name of the directory to helpers/vcpkg/ports/zeroc-ice_mumble and update the scripts accordingly.

Sounds good to me 👍

[ghost]

The port name can't have underscores. I'm looking at revising the script and directory.