Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Update vcpkg tools #18817

Merged
merged 12 commits into from
Jul 22, 2021
Merged

[vcpkg] Update vcpkg tools #18817

merged 12 commits into from
Jul 22, 2021

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Jul 5, 2021 •
edited
Loading

Fixes #18815
Fixes #18853
Fixes #18878

Updated:

  • perl: 5.30.0.1 -> 5.32.1.1
  • nuget: 5.5.1 -> 5.10.0
  • git: 2.26.2 -> 2.32.0.2
  • aria2: 1.34.0 -> 1.35.0
  • scons: 3.0.1 -> 4.0.1
  • go: 1.13.1 -> 1.16.6
  • doxygen: 1.8.17 -> 1.9.1
  • rubyInstaller: 2.6.3-1 -> 2.7.4-1
  • bazel: 3.7.0 -> 4.1.0
  • python3: 3.9.5 -> 3.9.6: it would be updated by [python3] Update to 3.9.6 #18754
  • llvm: 10.0.0 -> 12.0.0
  • meson: 0.58.0 -> 0.58.1
  • vswhere 2.41 -> 2.8.4
  • gsutil 4.59 -> 4.65

@PhoebeHui PhoebeHui added info:internal This PR or Issue was filed by the vcpkg team. category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Jul 5, 2021
@PhoebeHui PhoebeHui changed the title [perl/nuget] Update to latest release [vcpkg] Update vcpkg tools Jul 8, 2021
@Neumann-A
Copy link
Contributor

Please add NodeJS to vcpkg_find_acquire_program. This is required by qtwebengine in Qt 6.2

@PhoebeHui
Copy link
Contributor Author

@Neumann-A, from https://nodejs.org/en/download/, do we need both 32-bit and 64-bit nodejs for windows? should we add it for linux and macOS to vcpkg as well?

@Neumann-A
Copy link
Contributor

I thought the policy is to only add x84 and leave linux and osx to apt/brew

@xavier2k6
Copy link
Contributor

xavier2k6 commented Jul 9, 2021 •
edited
Loading

Please add:

#18878 gsutil 4.59 -> 4.65
#18879 CMake 3.20.2 -> CMake 3.20.5 Awaiting CMake 3.21 Release ref.: #18879 (comment)

@xavier2k6
Copy link
Contributor

@PhoebeHui
Git should be 2.32.0.2
ref.: https://github.com/git-for-windows/git/releases/

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 13, 2021
@xavier2k6
Copy link
Contributor

Will this be merged soon?

@PhoebeHui
Copy link
Contributor Author

@vicroms, could you help review and merge this PR?

BillyONeal
BillyONeal reviewed Jul 15, 2021
View reviewed changes
scripts/cmake/vcpkg_find_acquire_program.cmake Outdated
@@ -460,6 +464,19 @@ function(vcpkg_find_acquire_program VAR)
set(APT_PACKAGE_NAME pkg-config)
set(PATHS "/bin" "/usr/bin" "/usr/local/bin")
endif()
elseif(VAR MATCHES "NODE")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strega-nil @strega-nil-ms Should we add a tool port for this or are you OK expending in this way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strega-nil, what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have a tool port; I think we want to move off of vcpkg_find_acquire_program when possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would revert the changes for nodejs in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) please provide a tool template for that. Especially, have helper scripts for what normally vcpkg_find_acquire_program would do.
b) make vcpkg_find_acquire_program find programs in CURRENT_HOST_INSTALLED_DIR?
c) make vcpkg_find_acquire_program itself a helper script port?

@xavier2k6
Copy link
Contributor

@PhoebeHui
Looks like llvm was updated to 12.0.1 since PR was opened.... ref.: https://github.com/llvm/llvm-project/releases/
Also, meson -> 0.58.1 has a previous PR Open #18393 (didn't see this previously)

@PhoebeHui PhoebeHui mentioned this pull request Jul 16, 2021
Closed
@PhoebeHui
Copy link
Contributor Author

@xavier2k6, for llvm, I'd like to use llvm 12.0 at present. we can update it in next major release.

@xavier2k6
Copy link
Contributor

xavier2k6 commented Jul 17, 2021 •
edited
Loading

@PhoebeHui Apologies for the noise, again but Go got a CVE related update!

Go 1.16.6

Security: Includes a security fix for crypto/tls (CVE-2021-34558).

ref.:
https://groups.google.com/g/golang-announce/c/n9FxMelZGAQ/m/4ZhvTx0dAQAJ

EDIT:
RubyInstaller-2.7.4-1 Released - 2020-07-09
ref.:
https://github.com/oneclick/rubyinstaller2/releases/

@PhoebeHui
Copy link
Contributor Author

@xavier2k6, go and ruby have been upgrade to latest release, thanks!

@Neumann-A
Copy link
Contributor

In the meantime meson was updated to 58.2:
https://github.com/mesonbuild/meson/releases/tag/0.58.2

@vicroms vicroms merged commit 16aeda9 into microsoft:master Jul 22, 2021
@BillyONeal
Copy link
Member

I don't understand why this passed, it broke in CI:

You have bazel 4.1.0 installed.
Please downgrade your bazel installation to version 3.99.0 or lower to build TensorFlow! To downgrade: download the installer for the old version (from https://github.com/bazelbuild/bazel/releases) then run the installer.

https://dev.azure.com/vcpkg/public/_build/results?buildId=56564

Maybe we have to update tensorflow too?

@PhoebeHui
Copy link
Contributor Author

@BillyONeal, tensorflow has been triagerd, however it didn't run acutually.
See https://dev.azure.com/vcpkg/public/_build/results?buildId=55815&view=logs&j=c7e67a25-2047-5d01-7913-57de0573f534&t=0e07d234-e12f-5893-a7f1-2767a24f64ae

We will fix this issue in tensorflow ASAP, and report a request to Upstream as well.

@Cheney-W Cheney-W mentioned this pull request Jul 27, 2021
Merged
@PhoebeHui PhoebeHui deleted the dev/Phoebe/perl branch August 12, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoikas Hoikas Hoikas left review comments

@BillyONeal BillyONeal BillyONeal left review comments

@Neumann-A Neumann-A Neumann-A left review comments

@strega-nil-ms strega-nil-ms strega-nil-ms left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gsutil] update to 4.65 [vswhere] update to 2.8.4 [vcpkg tool] udpate to latest release
8 participants
@PhoebeHui @Neumann-A @xavier2k6 @BillyONeal @Hoikas @NancyLi1013 @strega-nil-ms @vicroms