[tensorflow] Update the max version of the supported bazel #19165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheney-W
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NancyLi1013
approved these changes
Jul 27, 2021
|
Do we have indications from upstream (in an issue or otherwise) that this is safe to do? |
|
It seems the right fix is to downgrade Bazel rather than patching this unless upstream is OK with it |
|
Upstream issue reported by us tensorflow/tensorflow#50966. They have created a PR tensorflow/tensorflow#50882 to support |
NancyLi1013
added
the
requires:vcpkg-team-review
Merged
|
Given that upstream is okay with this, I think this is good. |
strega-nil-ms
added
info:reviewed
|
Now, upstream reverted to the version 3.99 of |
This was referenced Jul 30, 2021
|
I'm merging this because upstream seems tentatively ok (they reverted only to split the change into a separate PR) and this is blocking all other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Since the PR #18817, the version of bazel used by vcpkg has been upgraded from 3.7.0 to 4.1.0, this causes tensorflow installation failed with following error:
For fixing this issue, I add a patch to modify the highest version of bazel supported by tensorflow to 4.1.0.
No feature need to be tested.