[meson] Update meson to 0.58.1

[Neumann-A]

No description provided.

[JackBoosY]

Does the simage regression related to meson changes?

[Neumann-A]

@JackBoosY: looks more like a problem with the TIFF wrapper

CMake Error at /Users/vagrant/Data/installed/x64-osx/share/jpeg/vcpkg-cmake-wrapper.cmake:1 (_find_package):
  _find_package for module JPEG called with REQUIRED, but
  CMAKE_DISABLE_FIND_PACKAGE_JPEG is enabled.  A REQUIRED package cannot be
  disabled.
Call Stack (most recent call first):
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:745 (include)
  /Users/vagrant/Data/installed/x64-osx/share/tiff/vcpkg-cmake-wrapper.cmake:17 (find_package)
  /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:745 (include)
  CMakeLists.txt:222 (find_package)


CMake Error at /Users/vagrant/Data/work/1/s/scripts/buildsystems/vcpkg.cmake:791 (_find_package):
  _find_package for module ZLIB called with REQUIRED, but
  CMAKE_DISABLE_FIND_PACKAGE_ZLIB is enabled.  A REQUIRED package cannot be
  disabled.

To be exact it is always using find_package(<something> REQUIRED) which is not correct. It needs to check <PackageName>_FIND_REQUIRED and <PackageName>_FIND_QUIETLY to set those options for the dependent ports correctly. Maybe find_dependency works in the wrapper? (Probably not; probably requires an ARGS MATCHES like syntax)

cc @dg0yt because of git blame ;)

[JackBoosY]

When building simage:x64-uwp that install tiff first:

     4>D:\buildtrees\simage\src\mage-1.8.0-17f988a113.clean\src\simage_tiff.c(88,18): error C4996: 'uint16': libtiff type deprecated; please use corresponding C99 stdint.h type 

[dg0yt]

looks more like a problem with the TIFF wrapper

• JPEG is required iff port tiff is used with feature "jpeg".
• ZLIB is required iff port tiff is used with feature "zip".
• jpeg, lzma and zip are opt-out features of port tiff because tiff was built with them before I updated that port.

Port simage is configured with CMAKE_DISABLE_FIND_PACKAGE_JPEG and CMAKE_DISABLE_FIND_PACKAGE_ZLIB for OSX_OR_WINDOWS. I don't know why this is done, but this conflicts with tiff's transitive dependencies.

So how about opting out from tiff's features "jpeg" and "zip" in port simage?

[Neumann-A]

@dg0yt

don't know why this is done, but this conflicts with tiff's transitive dependencies.

They are only required if and only if find_package(TIFF REQUIRED). If find_package(TIFF) is called the transitive dependencies should not be marked as REQUIRED. instead if the dependency is not satisfied TIFF_Found should be set to false.

[dg0yt]

When building simage:x64-uwp that install tiff first:

     4>D:\buildtrees\simage\src\mage-1.8.0-17f988a113.clean\src\simage_tiff.c(88,18): error C4996: 'uint16': libtiff type deprecated; please use corresponding C99 stdint.h type 

tiff 4.3.0 changed its type system. This was explicitly mentioned in #18187. With that PR, I patched a similar issue in port selene.

[dg0yt]

If find_package(TIFF) is called the transitive dependencies should not be marked as REQUIRED. instead if the dependency is not satisfied TIFF_Found should be set to false.

I see, it becomes clear with the simage example. Unfortunately it didn't come up during CI and review. I'm not sure if I can act quickly for tiff at the moment.

git grep REQUIRED ports/*/vcpkg-cmake-wrapper.cmake shows a few more hits which might need to be reviewed then.

[JackBoosY]

Depends on #18473. Since this is a tool update PR, I need to make sure all tests pass.

[dg0yt]

Does the simage regression related to meson changes?

Same as for gn update problem:
simage for windows triplets does not depend on tiff (and some other ports) so it must not use it. That's why it was not covered in CI for port tiff.

[BillyONeal]

I poked @ras0219 @ras0219-msft about the "vcpkg-find-acquire-program" server intermittent failure that got triggered by tool update

[dg0yt]

looks more like a problem with the TIFF wrapper
...
cc @dg0yt because of git blame ;)

For osx, I came to the conclusion that the error is one level above the TIFF wrapper: #18631

[JackBoosY]

looks more like a problem with the TIFF wrapper
...
cc @dg0yt because of git blame ;)

For osx, I came to the conclusion that the error is one level above the TIFF wrapper: #18631

Related: #18602.

[JackBoosY]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JackBoosY]

The gl3w:x86-windows regression will be fixed by another PR.

[JackBoosY]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[PhoebeHui]

The 'set(MESON_VERSION 0.58.0)' need to change the version to '0.58.1', since PR #18817 already covered all changes in this PR, @Neumann-A, do you mind to close this PR? or I can revert the changes in PR #18817.