[simage] Fix optional dependencies #15683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
force-pushed
the
dev/roschuma/simage
branch
from
a1f6f3d to
f938708
Compare
JackBoosY
added
category:port-bug
JackBoosY
approved these changes
Jan 18, 2021
dg0yt
reviewed
Jun 19, 2021
| Description: Image file format library abstraction layer | ||
| Build-Depends: giflib (linux|uwp), libjpeg-turbo (linux|uwp), libpng (linux|uwp), libsndfile (linux|uwp), tiff (linux|uwp), libvorbis (linux|uwp) | ||
| Build-Depends: giflib (!windows&!osx), libjpeg-turbo (!windows&!osx), libpng (!windows&!osx), libsndfile, tiff (!windows&!osx), libvorbis, zlib (!windows&!osx) |
There was a problem hiding this comment.
!windows also excludes uwp. This is different than before, and it doesn't align with the OSX_OR_WINDOWS variable in portfile.cmake. What is the desired state for UWP?
Now this caused the tiff update to 4.3.0 to pass through CI without testing simage, but hits CI for ports which happen to install tiff before simage for UWP: #17519, #18393, #18546
This was referenced Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.