Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS 2019 16.8 Preview 3 toolset update #1290

Merged
merged 2 commits into from
Sep 16, 2020
Merged

VS 2019 16.8 Preview 3 toolset update #1290

merged 2 commits into from
Sep 16, 2020

Conversation

StephanTLavavej
Copy link
Member

  • Update the Azure Virtual Machine Scale Set.
  • Update the README.
  • Unskip the libcxx test that was affected by (MS-internal bug) VSO-1035737, which was fixed in Preview 3.

@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Sep 15, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner September 15, 2020 03:44
@fsb4000
Copy link
Contributor

fsb4000 commented Sep 15, 2020 •
edited
Loading

What about #1152 ?
I just saw that the issue is marked "blocked on 16.8p3"

update:
Oh, now SuperWig created #1291
Okay, so be it. I just thought it could be included in this pull request...

@SuperWig
Copy link
Contributor

Oh I didn't realise this already had other work in this one. I figured STL would have prefered to have toolset updates to not include anything extra.

@StephanTLavavej
Copy link
Member Author

Thanks @fsb4000 and @SuperWig - I had simply created this toolset update PR very hastily the night before my talk (upon realizing that CppCon attendees newly installing 16.8p3 and building the repo would see a libcxx failure here) and simply hadn't searched for the issues marked blocked on 16.8p3. Having the separate PR does make things simpler, thank you!

@CaseyCarter CaseyCarter self-assigned this Sep 16, 2020
This was referenced Sep 16, 2020
Merged
Merged
@CaseyCarter CaseyCarter merged commit 5f3e912 into microsoft:master Sep 16, 2020
@CaseyCarter
Copy link
Contributor

Thanks for keeping our toolset current and unblocking the things waiting on 16.8p3!

@CaseyCarter CaseyCarter removed their assignment Sep 16, 2020
This was referenced Sep 16, 2020
Merged
Merged
@StephanTLavavej StephanTLavavej deleted the vs-2019-16.8-preview-3 branch September 16, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@cbezault cbezault cbezault approved these changes

Assignees
No one assigned
Labels
infrastructure Related to repository automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StephanTLavavej @fsb4000 @SuperWig @CaseyCarter @cbezault