Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change libcxx SKIPPED to FAIL when MSVC ships P0960 #1152

Closed
CaseyCarter opened this issue Aug 5, 2020 · 0 comments · Fixed by #1291
Closed

Change libcxx SKIPPED to FAIL when MSVC ships P0960 #1152

CaseyCarter opened this issue Aug 5, 2020 · 0 comments · Fixed by #1291
Labels
fixed Something works now, yay! test Related to test code

Comments

@CaseyCarter
Copy link
Contributor

MSVC has implemented (but not yet shipped) support for P0960R3 "Allow initializing aggregates from a parenthesized list of values". The libcxx test std/utilities/tuple/tuple.tuple/tuple.creation/tuple_cat.pass.cpp is broken by this C++20 feature, so we recently SKIPPED it in tests/libcxx/expected_results.txt and tests/libcxx/skipped_tests.txt. Once VS 2019 v 16.8p3 ships - which is expected to include the P0960 support - we should change the SKIPPED in tests/libcxx/expected_results.txt to an expected failure for MSVC only which IIRC corresponds to:

 # *** CLANG FEATURES NOT YET IMPLEMENTED ***
 # P0960R3 "Allow initializing aggregates from a parenthesized list of values"
-std/utilities/tuple/tuple.tuple/tuple.creation/tuple_cat.pass.cpp SKIPPED # TRANSITION, VS 2019 16.8 p3
+std/utilities/tuple/tuple.tuple/tuple.creation/tuple_cat.pass.cpp:0 FAIL

(A better fix would be to fix this test upstream and remove the skips, but we're currently blocked from updating LLVM due to LIT changes; see #1090.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Something works now, yay! test Related to test code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants