-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use constexpr is_sorted, add charconv tests, update comments #1278
Merged
StephanTLavavej
merged 9 commits into
microsoft:master
from
StephanTLavavej:small_fixes
Sep 23, 2020
Merged
Use constexpr is_sorted, add charconv tests, update comments #1278
StephanTLavavej
merged 9 commits into
microsoft:master
from
StephanTLavavej:small_fixes
Sep 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve-with-suggestions.
(microsoft/vscode-pull-request-github issue 2085 has been fixed but not yet released.)
Group issue 519 with the STL bugs.
8f2e72a
to
c094f1e
Compare
CaseyCarter
approved these changes
Sep 16, 2020
mnatsuhara
approved these changes
Sep 21, 2020
CaseyCarter
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Related to documentation or comments
enhancement
Something can be improved
test
Related to test code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are unrelated small changes to separate files - they could be split into separate PRs but I don't believe that would add any value.
constexpr is_sorted()
intools/parallelize/parallelize.cpp
. It's been available for a while, we just forgot about this occurrence.<execution>
comments to take advantage of hover cards in the GitHub Pull Requests And Issues extension for VSCode. (Show hover cards when issue numbers are followed by,
or.
vscode-pull-request-github#2085 has been fixed, but is not yet released.)printf()
has trouble with;<charconv>
was never affected but let's test these just in case.