Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constexpr is_sorted, add charconv tests, update comments #1278

Merged
merged 9 commits into from
Sep 23, 2020

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Sep 8, 2020

These are unrelated small changes to separate files - they could be split into separate PRs but I don't believe that would add any value.

@StephanTLavavej StephanTLavavej added documentation Related to documentation or comments enhancement Something can be improved test Related to test code labels Sep 8, 2020
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner September 8, 2020 03:38
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve-with-suggestions.

tests/libcxx/expected_results.txt Outdated Show resolved Hide resolved
tests/libcxx/expected_results.txt Outdated Show resolved Hide resolved
tests/libcxx/expected_results.txt Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej self-assigned this Sep 22, 2020
@StephanTLavavej StephanTLavavej merged commit d49e401 into microsoft:master Sep 23, 2020
@StephanTLavavej StephanTLavavej deleted the small_fixes branch September 23, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments enhancement Something can be improved test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants