Fix nested object get and set not working in res files

[jchavarri]

Fixes #489.

[jchavarri]

@anmonteiro the fix is ready (relevant commit: ef79a3b), but I think I need some help configuring dune so that rescript-syntax package is added as dep of this test. 😅

[jchavarri]

I think I need some help configuring dune so that rescript-syntax package is added as dep of this test.

I updated with latest main, but still see some error in ci due to rescript-syntax not being available:

- File "test/dune", line 13, characters 11-26:
- 13 |   (package rescript-syntax)))
-                 ^^^^^^^^^^^^^^^
- Error: Package rescript-syntax does not exist

I can reproduce when running dune build -p melange @runtest. I am surprised by this error, shouldn't dune just ignore tests from packages that are uninstalled? Related: ocaml/dune#3650

[anmonteiro]

-p is only-packages. How about dune build runtest -p melange,rescript-syntax,reactjs-jsx-ppx?

[jchavarri]

Yes, this works, see Makefile:

melange/Makefile

Lines 23 to 24 in f550ed9

	test:
	opam exec -- dune runtest -p melange,rescript-syntax,reactjs-jsx-ppx

The problem happens when installing melange, because melange.opam has the following on build:

melange/melange.opam

Lines 24 to 31 in f550ed9

	"dune"
	"build"
	"-p"
	name
	"-j"
	jobs
	"@install"
	"@runtest" {with-test}

[anmonteiro]

Ah. Feel free to not run the tests then. I remove that line from the opam file when we release to opam too.

[jchavarri]

I disabled rescript-syntax tests in ff9a0c5. But this was quite unfortunate as there seems to be no way to keep checking the test added in this PR in the future.

So I followed a different alternative in e2073f8:

• add the new rescript-syntax test to melange package
• remove the --with-test flags when pinning the 3 packages melange, rescript-syntax and reactjs-jsx-ppx in opam-install-test
• add back make test to ci

That way, we can keep testing everything while working around dune limitation for running tests with -p. Lmk what you think! :)

[jchavarri]

Meh, it worked locally, but in ci everything breaks. Nix build is broken and opam build as well. Will take another stab at this later.

[anmonteiro]

Happy to fix the nix stuff. the opam build is failing because reason isn't installed

[jchavarri]

@anmonteiro I think I got it to a point where everything works without any workarounds. There were a series of issues. I ended up creating a folder test/rescript-syntax and moving the new test of this package over there, to avoid having to use applies_to, which seems it's a bit buggy and cumbersome to use. I also started using %{bin:xxx} dependencies rather than package ones, which seems to work and doesn't lead into the issue you reported in ocaml/dune#7220.

[anmonteiro]

Thank you!