Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: promote test files #537

Merged
merged 1 commit into from
Apr 7, 2023
Merged

chore: promote test files #537

merged 1 commit into from
Apr 7, 2023

Conversation

anmonteiro
Copy link
Member

this chnged after #526

@anmonteiro anmonteiro merged commit 907fb95 into main Apr 7, 2023
@anmonteiro anmonteiro deleted the anmonteiro/promote-test-dist branch April 7, 2023 05:49
@jchavarri
Copy link
Member

jchavarri commented Apr 7, 2023 •
edited
Loading

Thanks! Is there a way to detect in CI when these files should be updated?

jchavarri added a commit that referenced this pull request Apr 11, 2023
@jchavarri
Merge branch 'main' into gh-489
f6acce2 
* main:
  melange: Add a `melpp` executable that just preprocesses conditionals (#539)
  Promote test files (#537)
  chore: update nix flake (#536)
@anmonteiro
Copy link
Member Author

I check this from time to time. the test dir is excluded in https://github.com/melange-re/melange/blob/main/jscomp/dune#L1 to avoid adding time to the build but we probably need a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmonteiro @jchavarri