stdlib: put all sources in same folder on installation #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
commented
Mar 22, 2023
jscomp/stdlib-412/dune
Outdated
| @@ -1,4 +1,4 @@ | |||
| (include_subdirs unqualified) | |||
| (copy_files# ./stdlib_modules/*.ml{,i}) | |||
There was a problem hiding this comment.
I am not sure the # is doing anything in this case. They point to e.g.
# 1 "jscomp/stdlib-412/stdlib_modules/weak.ml"
But the file is in _opam/lib/melange/weak.ml —due to the further copying in (dir melange) rule specified in lib/dune— so it can't find the reference.
I think we can just use copy_files?
There was a problem hiding this comment.
yup, fine to use copy_files.
anmonteiro
reviewed
Mar 22, 2023
anmonteiro
approved these changes
Mar 22, 2023
done in 0f0851e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merlin struggles going to definition of submodules of the
Stdlibbecause they are placed in a different folder (stdlib_modules) than the wrap moduleStdlib, which is one folder up.This PR changes that so that all sources of
Stdlibare placed in the same module. Rather than moving the files up, we usecopy_files#for backwards compat with bsconfig workflows (@anmonteiro dixit).