Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dune to latest #540

Merged
merged 5 commits into from
Apr 11, 2023
Merged

update dune to latest #540

merged 5 commits into from
Apr 11, 2023

Conversation

jchavarri
Copy link
Member

No description provided.

@jchavarri
Copy link
Member Author

@anmonteiro I noticed something changed in latest version of melange that broke the tests. In the second commit c09e3ba I "fixed" it by using (emit_stdlib false), but the fix is more of a workaround, as it makes impossible to use Melange stdlib and shadow some of the modules in it. Do you have any clue why shadowing becomes impossible now?

@anmonteiro
Copy link
Member

Do you have any clue why shadowing becomes impossible now?

because the stdlib includes need to be added at the end. if you use emit_stdlib true they're added to the set of required libraries, and their includes aren't in that expected order.

@jchavarri could you add the changes in #530 too?

@jchavarri jchavarri marked this pull request as ready for review April 10, 2023 16:24
@jchavarri jchavarri requested a review from anmonteiro April 10, 2023 16:24
@jchavarri
Copy link
Member Author

could you add the changes in #530 too?

Done.

@anmonteiro anmonteiro merged commit dd000c2 into main Apr 11, 2023
@anmonteiro anmonteiro deleted the update-dune branch April 11, 2023 05:18
jchavarri added a commit that referenced this pull request Apr 11, 2023
@jchavarri
Merge branch 'main' into gh-489
8238d8b 
* main:
  update dune to latest (#540)
@jchavarri jchavarri mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro Awaiting requested review from anmonteiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchavarri @anmonteiro