Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 25268 #25728

Closed
wants to merge 44 commits into from
Closed

Issue 25268 #25728

wants to merge 44 commits into from

Conversation

rajeebkumar-sahoo
Copy link

resolved issue#25268: order get customer returns null from observer

Description (*)

This merge request resolves issue#25268 (order get customer returns null from observer)

Fixed Issues (if relevant)

  1. $order->getCustomer() returns NULL for registered customer #25268: $order->getCustomer() returns NULL for registered customer

Manual testing scenarios (*)

Pre-requisite:
i. setup:di:compile after getting the new code
ii. clean the configuration cache after adding event observer

  1. Create one observer for event "sales_order_save_after".
  2. Place an order with a registered customer account.
  3. Try to access customer object from order object within the observer created above.
  4. You will be able to get customer data instead of null after this fix.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rajeebkumar-sahoo,

  1. First of all - there is a lot not related changes. Could you force push only needed changes?
  2. I don't see any difference in order model, looks like you missed to push them

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:12
@VladimirZaets VladimirZaets self-assigned this Dec 16, 2019
@VladimirZaets
Copy link
Contributor

@rajeebkumar-sahoo , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@m2-assistant
Copy link

m2-assistant bot commented Dec 16, 2019

Hi @rajeebkumar-sahoo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.