-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old logic to make search by operation status possible #25569
Conversation
Hi @nuzil. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @aleron75, thank you for the review.
|
@nuzil do you think a test is needed for this change? |
@aleron75 I thought about that, but statuses tests we already have and this change is not affecting on them, they are correctly valid and will test existed functionality correctly. |
Sorry @aleron75 |
I forgive you :-D |
Hi @aleron75, thank you for the review. |
✔️ QA Passed |
Hi @nuzil, thank you for your contribution! |
Description (*)
Idea of this PR is to make Search by operation statuses work again.
Removed functionality with current Async Operations implementation will always return zero results if you will search by operation status = 4 (open).
Manual testing scenarios (*)
Schedule some operation, for example Bulk API, but do not run consumers.
Contribution checklist (*)