Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old logic to make search by operation status possible #25569

Merged
merged 5 commits into from
Nov 24, 2019

Conversation

nuzil
Copy link
Contributor

@nuzil nuzil commented Nov 12, 2019

Description (*)

Idea of this PR is to make Search by operation statuses work again.

Removed functionality with current Async Operations implementation will always return zero results if you will search by operation status = 4 (open).

Manual testing scenarios (*)

Schedule some operation, for example Bulk API, but do not run consumers.

  1. Try to search by API: GET {{URL}}rest/V1/bulk/UUID/operation-status/4
  2. You will receive same qty as amount of operations you sheduled
  3. Run consumers
  4. Run call no 2 and see how QTY is reducing to 0

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2019

Hi @nuzil. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6292 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@aleron75
Copy link
Contributor

@nuzil do you think a test is needed for this change?

@nuzil
Copy link
Contributor Author

nuzil commented Nov 18, 2019

@aleron75 I thought about that, but statuses tests we already have and this change is not affecting on them, they are correctly valid and will test existed functionality correctly.
Another point, that on tests environment queue is always executing, this mean directly I'm scheduling messages, they are picked up by consumers, so I'm not sure its possible to provide valid Test for OPEN statuses with current infrastructure

@engcom-Alfa engcom-Alfa self-assigned this Nov 21, 2019
@nuzil
Copy link
Contributor Author

nuzil commented Nov 21, 2019

Sorry @aleron75
I wrote some tests :-D

@aleron75 aleron75 added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Nov 22, 2019
@aleron75
Copy link
Contributor

Sorry @aleron75
I wrote some tests :-D

I forgive you :-D

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6292 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 22, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2019

Hi @nuzil, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: AsynchronousOperations Partner: Comwrap partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants