Uses > Used for Yes/No column in coupons grid

[sta1r]

Description (*)

In the grid for coupon codes on each Cart Price Rule entry, there is a column for 'Uses' with options for Yes/No. This column is intended to indicate if a coupon has been used or not, so the header should be 'Used'.

Manual testing scenarios (*)

1. Go to Marketing > Promotions > Cart Price Rules
2. Create a new rule and save it
3. Generate some coupons against the rule
4. See amended 'Used' column header

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @sta1r. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-6299 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

Hi, @sta1r Could you change this word and in the translation file?
Thanks!

[engcom-Alfa]

✔️ QA Passed

[lbajsarowicz]

About MFTF coverage: I'm not convinced to use that kind of tests, as it expects to have 'Used' at 4th position and it's really coupled with language, so when someone wants to test specific language - this will be another stepKey to customize.

CC: @okolesnyk

[okolesnyk]

Hi @lbajsarowicz
We should provide possibility to use translations in MFTF tests. We have an issue#484 opened in MFTF repo and our team will provide solution for this. As for now I think we can move forward with current solution.
The only one comment I have is try to avoid using indices in selectors. In current situation I do recommend to create separate element only for Used column header which can look like this: #couponCodesGrid thead th[data-sort='used']

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-6299 has been created to process this Pull Request

[m2-assistant]

Hi @sta1r, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.