Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 7897 #15399

Closed
wants to merge 47 commits into from
Closed

Issue 7897 #15399

wants to merge 47 commits into from

Conversation

Abdulrahimbadiyal
Copy link

Description

fixed Menu widget submenu alignment

Fixed Issues (if relevant)

  1. Menu widget submenu alignment #7897:
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

IgorVitol and others added 30 commits May 8, 2018 14:01
@IgorVitol
Add 'const' type support to layout arguments
51000b9
@magento-engcom-team
ENGCOM-1473: Add 'const' type support to layout arguments magento#15058
825832b 
 - Merge Pull Request magento#15058 from IgorVitol/magento2:2.2-develop-const-layout-argument
 - Merged commits:
   1. 51000b9
@vovayatsyuk
Sync braintree config with customer's data.
6a7d40a 
This commit fixes the case when customer navigates back
to the shipping step and change address fields.
@vovayatsyuk
JSDoc fix
8712f3e
@vovayatsyuk
Fixed failed test
d6ba03c
@vovayatsyuk
ESLint and JSCS fixes
ebd8af4
@magento-engcom-team
ENGCOM-1513: Fix outdated address data when using Braintree's 'Pay wi…
0b786fe 
…th PayPal' button magento#15133

 - Merge Pull Request magento#15133 from vovayatsyuk/magento2:fix-braintree-outdated-address
 - Merged commits:
   1. 6a7d40a
   2. 8712f3e
   3. d6ba03c
   4. ebd8af4
@t-richards
Fix typo in Image::open exception message
9d64743
[fix] typo in method name _getCharg[e]ableOptionPrice
ef68020
@magento-engcom-team
ENGCOM-1582: Fix typo in Image::open exception message magento#15269
d1953f1 
 - Merge Pull Request magento#15269 from t-richards/magento2:fix/image-exception-typo
 - Merged commits:
   1. 9d64743
[fix] typo in private method name getUniq[ue]ImageIndex
541fdf6
@magento-engcom-team
ENGCOM-1584: [fix] typo in private method name getUniq[ue]ImageIndex m…
7dbc62a 
…agento#15282

 - Merge Pull Request magento#15282 from mhauri/magento2:fix-typo-in-method-getuniqimageindex
 - Merged commits:
   1. 541fdf6
@VitaliyBoyko
Fix typo in database column comment
1d518fd
@magento-engcom-team
ENGCOM-1586: [Backport] Fix typo in database column comment magento#1…
22c058a 
…5291

 - Merge Pull Request magento#15291 from VitaliyBoyko/magento2:Fix-typo-in-database-column-comment2-2
 - Merged commits:
   1. 1d518fd
@dmytro-ch
Fix typo in property name
f665db5
@dmytro-ch
Merge branch '2.2-develop' into fix/2.2-fix-typos-in-property-name
076e60a
@dmytro-ch
Fix typos in PHPDocs and comments
08575f3
@dmytro-ch
Fix typos in variable names
4f85f87
@dmytro-ch
Fix typo in DeploymentConfig class
ad501a9
@magento-engcom-team
ENGCOM-1587: Fix typo in property name magento#15292
cbe91ae 
 - Merge Pull Request magento#15292 from dmytro-ch/magento2:fix/2.2-fix-typos-in-property-name
 - Merged commits:
   1. f665db5
   2. 076e60a
[task] add deprecated notice to misspelled method
8ea661c
@sanganinamrata
Fixed typo mistake in function comment
48a8b1d
@sanganinamrata
Removed extra added space in function comment and fixed typo mistakes.
1e1ceb9
@sanganinamrata
Revert back file changes
298e392
@sanganinamrata
Revert back file changes.
44031e0
@sanganinamrata
Merge branch 'ns-patch-8' of https://github.com/NamrataChangani/magento2
c4db071 
 into ns-patch-1
@VladimirZaets
ENGCOM-1587: Fix typo in property name magento#15292
630faa1
@VladimirZaets
ENGCOM-1586: [Backport] Fix typo in database column comment magento#1…
96d31f5 
…5291
@VladimirZaets
ENGCOM-1584: [fix] typo in private method name getUniq[ue]ImageIndex m…
807ab61 
…agento#15282
@VladimirZaets
ENGCOM-1582: Fix typo in Image::open exception message magento#15269
c920e3e
VladimirZaets and others added 17 commits May 19, 2018 01:29
@VladimirZaets
ENGCOM-1513: Fix outdated address data when using Braintree's "Pay wi…
94759da 
…th PayPal" button magento#15133
@VladimirZaets
ENGCOM-1473: Add 'const' type support to layout arguments magento#15058
819c65e
@VitaliyBoyko
Unused variable removed
b40aae2
🔃 [EngCom] Public Pull Requests - 2.2-develop
9a28908 
Accepted Public Pull Requests:
 - magento#15292: Fix typo in property name (by @dmytro-ch)
 - magento#15291: [Backport] Fix typo in database column comment (by @VitaliyBoyko)
 - magento#15282: [fix] typo in private method name getUniq[ue]ImageIndex (by @mhauri)
 - magento#15269: Fix typo in Image::open exception message (by @t-richards)
 - magento#15133: Fix outdated address data when using Braintree's "Pay with PayPal" button (by @vovayatsyuk)
 - magento#15058: Add 'const' type support to layout arguments (by @IgorVitol)
@magento-engcom-team
ENGCOM-1593: [Backport-2.2] Unused variable removed magento#15386
1da6d36 
 - Merge Pull Request magento#15386 from VitaliyBoyko/magento2:Unused-variable-removed2-2
 - Merged commits:
   1. b40aae2
@magento-engcom-team
ENGCOM-1599: Fixed typo mistake in function comment magento#15302
54ffb8c 
 - Merge Pull Request magento#15302 from NamrataChangani/magento2:ns-patch-1
 - Merged commits:
   1. 48a8b1d
   2. 1e1ceb9
   3. 298e392
   4. 44031e0
   5. c4db071
@magento-engcom-team
ENGCOM-1602: Fix typos in variable names magento#15294
288c1b6 
 - Merge Pull Request magento#15294 from dmytro-ch/magento2:fix/2.2-typos-in-variable-names
 - Merged commits:
   1. 4f85f87
@magento-engcom-team
ENGCOM-1580: [fix] typo in method name _getCharg[e]ableOptionPrice ma…
62050b8 
…gento#15276

 - Merge Pull Request magento#15276 from mhauri/magento2:fix-typo-in-method-chargable
 - Merged commits:
   1. ef68020
   2. 8ea661c
@magento-engcom-team
ENGCOM-1588: Fix typos in PHPDocs and comments magento#15293
b295a28 
 - Merge Pull Request magento#15293 from dmytro-ch/magento2:fix/2.2-typos-in-phpdocs-and-comments
 - Merged commits:
   1. 08575f3
   2. ad501a9
ENGCOM-1602: Fix typos in variable names magento#15294
a3f8bd5
ENGCOM-1599: Fixed typo mistake in function comment magento#15302
bd027a7
ENGCOM-1593: [Backport-2.2] Unused variable removed magento#15386
ae634b4
ENGCOM-1588: Fix typos in PHPDocs and comments magento#15293
a6c4865
ENGCOM-1580: [fix] typo in method name _getCharg[e]ableOptionPrice ma…
2bd2994 
…gento#15276
🔃 [EngCom] Public Pull Requests - 2.2-develop
32892a4 
Accepted Public Pull Requests:
 - magento#15294: Fix typos in variable names (by @dmytro-ch)
 - magento#15302: Fixed typo mistake in function comment (by @namratachangani)
 - magento#15386: [Backport-2.2] Unused variable removed (by @VitaliyBoyko)
 - magento#15293: Fix typos in PHPDocs and comments (by @dmytro-ch)
 - magento#15276: [fix] typo in method name _getCharg[e]ableOptionPrice (by @mhauri)
@Abdulrahimbadiyal
issue:7897 fixed - Menu widget submenu alignment
48b9597
@Abdulrahimbadiyal
issue:7897 fixed - Menu widget submenu alignment
f2ce324
@magento-engcom-team
Copy link
Contributor

Hi @Abdulrahimbadiyal
Unfortunately, we only accept Pull Requests to the following branches: 2.1-develop, 2.2-develop, 2.3-develop.
Please create a new Pull Request and use one of those as a target.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Abdulrahimbadiyal @magento-engcom-team @IgorVitol @vovayatsyuk @t-richards @VitaliyBoyko @dmytro-ch @sanganinamrata @VladimirZaets