Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu widget submenu alignment #7897

Closed
slackerzz opened this issue Dec 20, 2016 · 9 comments
Closed

Menu widget submenu alignment #7897

slackerzz opened this issue Dec 20, 2016 · 9 comments
Assignees
@hitesh-wagento
Labels
bug report Component: Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted

Comments

@slackerzz
Copy link
Member

Preconditions

  1. Magento 2.0.x, 2.1.x

Steps to reproduce

  1. hover a menu item which contains some nested elements

Expected result

  1. the submenu relative to the "Bottoms 2" element in the image should be aligned next to it

Actual result

menu
If you move your mouse slowly you'll never be able to click any of the submenu items

The js from the widget calculates coordinates for the submenu:
coords

but then we have this LESS
https://github.com/magento/magento2/blob/develop/lib/web/css/source/lib/_navigation.less#L403

Simply removing the to !important rules does not fix the problem, there is something wrong also in the coords calculated via js

Since this widget is based on https://jqueryui.com/menu/ that works as expected i think that something went wrong and someone tried to fix it with an !important to overwrite an inline style added via js
@AlexWorking
Copy link

AlexWorking commented Jun 21, 2017 •
edited
Loading

Hi @slackerzz. An internal ticket MAGETWO-70053 has been created based on Your issue. You'll be immediately notified after the issue is resolved. Thank You for appliance.

@veloraven veloraven added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Progress: needs update labels Jun 29, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Catalog Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@slackerzz, thank you for your report.
We've created internal ticket(s) MAGETWO-80700 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@Abdulrahimbadiyal
Copy link

I'm working on it #dmcdindia

@magento-engcom-team
Copy link
Contributor

@Abdulrahimbadiyal thank you for joining. Please accept team invitation here and self-assign the issue.

@Abdulrahimbadiyal Abdulrahimbadiyal self-assigned this May 19, 2018
@Abdulrahimbadiyal Abdulrahimbadiyal mentioned this issue May 21, 2018
Closed
4 tasks
@hitesh-wagento
Copy link
Contributor

I am working on this

@hitesh-wagento hitesh-wagento self-assigned this Jun 1, 2018
hitesh-wagento added a commit to hitesh-wagento/magento2 that referenced this issue Jun 1, 2018
@hitesh-wagento
[Resolved : Menu widget submenu alignment magento#7897]
2694906
@hitesh-wagento hitesh-wagento mentioned this issue Jun 1, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @slackerzz. Thank you for your report.
The issue has been fixed in #15645 by @hitesh-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 2, 2018
magento-engcom-team added a commit that referenced this issue Jun 2, 2018
@magento-engcom-team
ENGCOM-1762: [Resolved : Menu widget submenu alignment #7897] #15645
e49ada9 
 - Merge Pull Request #15645 from hitesh-wagento/magento2:feature-menu-widget-submenu
 - Merged commits:
   1. 2694906
magento-engcom-team pushed a commit that referenced this issue Jun 2, 2018
ENGCOM-1762: [Resolved : Menu widget submenu alignment #7897] #15645
a74c646
This was referenced Jun 3, 2018
Merged
Merged
@hitesh-wagento hitesh-wagento mentioned this issue Jun 4, 2018
Closed
4 tasks
@sidolov
Copy link
Contributor

sidolov commented Jun 4, 2018

Hi @slackerzz. Thank you for your report.
The issue has been fixed in #15714 by @dmytro-ch in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 4, 2018
magento-engcom-team added a commit that referenced this issue Jun 4, 2018
@magento-engcom-team
ENGCOM-1796: [Backport] [Resolved : Menu widget submenu alignment #7897…
648a86c 
…] #15714

 - Merge Pull Request #15714 from dmytro-ch/magento2:2.1-develop-PR-port-15645
 - Merged commits:
   1. 57fed5a
magento-engcom-team pushed a commit that referenced this issue Jun 4, 2018
ENGCOM-1796: [Backport] [Resolved : Menu widget submenu alignment #7897…
24caaf9 
…] #15714
This was referenced Jun 4, 2018
Closed
Merged
@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 5, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 5, 2018

Hi @slackerzz. Thank you for your report.
The issue has been fixed in #15764 by @hitesh-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov
Copy link
Contributor

sidolov commented Jun 5, 2018

Hi @slackerzz. Thank you for your report.
The issue has been fixed in #15709 by @dmytro-ch in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team added a commit that referenced this issue Jun 5, 2018
@magento-engcom-team
ENGCOM-1793: [Forwardport] [Resolved : Menu widget submenu alignment #…
6736223 
…7897] #15709

 - Merge Pull Request #15709 from dmytro-ch/magento2:2.3-develop-PR-port-15645
 - Merged commits:
   1. 14bf8af
magento-engcom-team pushed a commit that referenced this issue Jun 5, 2018
@VladimirZaets
ENGCOM-1793: [Forwardport] [Resolved : Menu widget submenu alignment #…
c665b89 
…7897] #15709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitesh-wagento hitesh-wagento

Labels
bug report Component: Catalog Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@slackerzz @veloraven @sidolov @hitesh-wagento @AlexWorking @Abdulrahimbadiyal @magento-engcom-team