Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] typo in private method name getUniq[ue]ImageIndex #15282

Merged
merged 1 commit into from
May 20, 2018
Merged

[fix] typo in private method name getUniq[ue]ImageIndex #15282

merged 1 commit into from
May 20, 2018

Conversation

mhauri
Copy link

@mhauri mhauri commented May 17, 2018 •
edited
Loading

Description

Private method name \Magento\Catalog\Console\Command\ImagesResizeCommand::getUniqImageIndex contained typo/misspelling.

Renamed it to getUniqueImageIndex.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 17, 2018
@DanielRuf DanielRuf self-requested a review May 17, 2018 21:09
@magento-engcom-team magento-engcom-team merged commit 541fdf6 into magento:2.2-develop May 20, 2018
magento-engcom-team pushed a commit that referenced this pull request May 20, 2018
@VladimirZaets
ENGCOM-1584: [fix] typo in private method name getUniq[ue]ImageIndex #…
807ab61 
…15282
@magento-engcom-team
Copy link
Contributor

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@eduard13 eduard13 mentioned this pull request Jul 12, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees

@rogyar rogyar

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@mhauri @magento-engcom-team @DanielRuf @rogyar