-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 New Crowdin updates #1338
🌐 New Crowdin updates #1338
Conversation
[ci skip]
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
WalkthroughThis pull request introduces new key-value pairs in localization files for German, Danish, and Portuguese emails, adding preview messages related to polls. It includes minor syntactical changes, such as trailing commas in existing entries. Additionally, several keys related to unavailable features have been removed across multiple languages, indicating a shift in functionality. New strings for error handling during image uploads are added in English, Dutch, Finnish, Swedish, and Brazilian Portuguese localization files, enhancing user communication regarding uploads and polls. Changes
Possibly related PRs
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Additional comments not posted (10)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/emails/locales/de/emails.json (1 hunks)
Additional comments not posted (2)
packages/emails/locales/de/emails.json (2)
48-48
: Approved: Trailing comma addition.The addition of the trailing comma is correct and follows JSON syntax best practices, facilitating future additions to the JSON object.
49-49
: Approved: New key-value pair addition.The addition of
"newPoll_preview": "Teilen Sie den Einladungslink, um mit dem Sammeln von Antworten zu beginnen."
is correctly formatted and enhances the functionality by providing a clear prompt for user engagement.
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/web/public/locales/hu/app.json (1 hunks)
- packages/emails/locales/hu/emails.json (1 hunks)
Files skipped from review due to trivial changes (2)
- apps/web/public/locales/hu/app.json
- packages/emails/locales/hu/emails.json
[ci skip]
[ci skip]
[ci skip]
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- apps/web/public/locales/eu/app.json (1 hunks)
- apps/web/public/locales/fi/app.json (1 hunks)
- apps/web/public/locales/hu/app.json (1 hunks)
- apps/web/public/locales/nl/app.json (1 hunks)
Files skipped from review due to trivial changes (3)
- apps/web/public/locales/eu/app.json
- apps/web/public/locales/fi/app.json
- apps/web/public/locales/nl/app.json
Additional comments not posted (1)
apps/web/public/locales/hu/app.json (1)
279-279
: Approved: UpdatedprofilePictureDescription
for clarity.The modification to the
profilePictureDescription
key enhances clarity by explicitly stating the maximum file size, which improves user comprehension.
[ci skip]
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/web/public/locales/en/app.json (1 hunks)
- apps/web/public/locales/hu/app.json (1 hunks)
Files skipped from review due to trivial changes (1)
- apps/web/public/locales/hu/app.json
Additional comments not posted (1)
apps/web/public/locales/en/app.json (1)
284-285
: Approved: New error handling strings added.The new strings
"errorUploadPicture"
and"errorUploadPictureDescription"
are clear and align well with the rest of the localization file. They enhance user experience by providing specific feedback on upload failures.
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/nl/app.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- apps/web/public/locales/nl/app.json
[ci skip]
[ci skip]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/web/public/locales/da/app.json (1 hunks)
- packages/emails/locales/da/emails.json (1 hunks)
Additional comments not posted (2)
packages/emails/locales/da/emails.json (1)
49-49
: LGTM!The new key-value pair
"newPoll_preview"
has been added correctly to provide the localized preview message when creating a new poll.apps/web/public/locales/da/app.json (1)
276-285
: LGTM!The new key-value pairs related to profile picture management have been added correctly:
"removeAvatar"
: Localized string for the action to remove the avatar."uploadProfilePicture"
: Localized string for the action to upload a profile picture."profilePictureDescription"
: Localized description of the profile picture requirements."invalidFileType"
: Localized error message for an invalid file type."invalidFileTypeDescription"
: Localized description of the allowed file types."fileTooLarge"
: Localized error message for a file that is too large."fileTooLargeDescription"
: Localized description of the maximum file size."errorUploadPicture"
: Localized error message for a generic upload error."errorUploadPictureDescription"
: Localized description of the generic upload error.The changes are approved.
[ci skip]
[ci skip]
[ci skip]
[ci skip]
Summary by CodeRabbit