Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1338

Merged
merged 18 commits into from
Sep 13, 2024
Merged

🌐 New Crowdin updates #1338

merged 18 commits into from
Sep 13, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Sep 9, 2024

Summary by CodeRabbit

  • New Features
    • Added a preview message in German, Danish, and Portuguese emails to prompt users about sharing an invitation link for collecting responses to polls.
    • Introduced new error messages for upload failures in multiple languages (English, Dutch, Danish, Swedish, Portuguese) to improve user feedback during profile picture uploads.
    • Updated the Hungarian localization for profile picture description to clarify the maximum file size limit.
    • Enhanced the Danish localization with new messages for profile picture management and error handling.
    • Added new messages for removing an avatar and improved error handling in Swedish localization.
  • Bug Fixes
    • Removed outdated feature availability messages in multiple languages (Hungarian, Basque, Finnish, Dutch) to enhance user experience.

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 5:23pm
landing ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 5:23pm

Copy link
Contributor

coderabbitai bot commented Sep 9, 2024

Walkthrough

This pull request introduces new key-value pairs in localization files for German, Danish, and Portuguese emails, adding preview messages related to polls. It includes minor syntactical changes, such as trailing commas in existing entries. Additionally, several keys related to unavailable features have been removed across multiple languages, indicating a shift in functionality. New strings for error handling during image uploads are added in English, Dutch, Finnish, Swedish, and Brazilian Portuguese localization files, enhancing user communication regarding uploads and polls.

Changes

File Change Summary
packages/emails/locales/de/emails.json Added "newPoll_preview": "Teilen Sie den Einladungslink, um mit dem Sammeln von Antworten zu beginnen." and modified "newComment_heading" to include a trailing comma.
packages/emails/locales/da/emails.json Added "newPoll_preview": "Del dit deltagerlink, for at begynde at indsamle svar." and modified "newComment_heading" to include a trailing comma.
packages/emails/locales/pt-BR/emails.json Added "newPoll_preview": "Compartilhe seu link de participante para começar a coletar respostas." and modified "newComment_heading" to include a trailing comma.
apps/web/public/locales/en/app.json Removed "featureNotAvailable" and "featureNotAvailableDescription"; added "errorUploadPicture" and "errorUploadPictureDescription".
apps/web/public/locales/hu/app.json Modified "profilePictureDescription" from "2MB-ig, JPG vagy PNG" to "Max. 2 MB, JPG vagy PNG". Removed "featureNotAvailable" and "featureNotAvailableDescription".
apps/web/public/locales/eu/app.json Removed "featureNotAvailable" and "featureNotAvailableDescription".
apps/web/public/locales/fi/app.json Removed "featureNotAvailable" and "featureNotAvailableDescription".
apps/web/public/locales/nl/app.json Removed "featureNotAvailable" and "featureNotAvailableDescription"; added "errorUploadPicture" and "errorUploadPictureDescription".
apps/web/public/locales/da/app.json Added multiple new keys for profile picture management and error handling.
apps/web/public/locales/sv/app.json Added "errorUploadPicture": "Det gick inte att ladda upp" and "errorUploadPictureDescription": "Det uppstod ett problem med att ladda upp din bild. Försök igen senare." and added "removeAvatar": "Ta bort"; modified "fileTooLargeDescription" to "fileTooLarge": "För stor fil".
apps/web/public/locales/pl/app.json Added multiple new keys related to profile picture management and error handling.

Possibly related PRs

🐰 In the meadow, a message anew,
A link to share, for me and for you.
With polls to gather, responses will flow,
A clearer path for all to know.
Hops of joy in the digital space,
Together we thrive, in this friendly place! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8920760 and 74455a2.

Files selected for processing (2)
  • apps/web/public/locales/pl/app.json (1 hunks)
  • packages/emails/locales/pl/emails.json (1 hunks)
Additional comments not posted (10)
packages/emails/locales/pl/emails.json (1)

49-49: LGTM!

The code changes are approved:

  • The addition of the new key-value pair for the "newPoll_preview" entry is consistent with the PR objectives.
  • The Polish translation seems appropriate for the preview message of a new poll feature.
  • The JSON syntax is valid.
  • The placement of the new entry is appropriate.
apps/web/public/locales/pl/app.json (9)

277-277: LGTM!

The code segment is approved.


278-278: LGTM!

The code segment is approved.


279-279: LGTM!

The code segment is approved.


280-280: LGTM!

The code segment is approved.


281-281: LGTM!

The code segment is approved.


282-282: LGTM!

The code segment is approved.


283-283: LGTM!

The code segment is approved.


284-284: LGTM!

The code segment is approved.


285-285: LGTM!

The code segment is approved.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1276bc2 and 8b2508a.

Files selected for processing (1)
  • packages/emails/locales/de/emails.json (1 hunks)
Additional comments not posted (2)
packages/emails/locales/de/emails.json (2)

48-48: Approved: Trailing comma addition.

The addition of the trailing comma is correct and follows JSON syntax best practices, facilitating future additions to the JSON object.


49-49: Approved: New key-value pair addition.

The addition of "newPoll_preview": "Teilen Sie den Einladungslink, um mit dem Sammeln von Antworten zu beginnen." is correctly formatted and enhances the functionality by providing a clear prompt for user engagement.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8b2508a and e9026b4.

Files selected for processing (2)
  • apps/web/public/locales/hu/app.json (1 hunks)
  • packages/emails/locales/hu/emails.json (1 hunks)
Files skipped from review due to trivial changes (2)
  • apps/web/public/locales/hu/app.json
  • packages/emails/locales/hu/emails.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e9026b4 and e450ee9.

Files selected for processing (4)
  • apps/web/public/locales/eu/app.json (1 hunks)
  • apps/web/public/locales/fi/app.json (1 hunks)
  • apps/web/public/locales/hu/app.json (1 hunks)
  • apps/web/public/locales/nl/app.json (1 hunks)
Files skipped from review due to trivial changes (3)
  • apps/web/public/locales/eu/app.json
  • apps/web/public/locales/fi/app.json
  • apps/web/public/locales/nl/app.json
Additional comments not posted (1)
apps/web/public/locales/hu/app.json (1)

279-279: Approved: Updated profilePictureDescription for clarity.

The modification to the profilePictureDescription key enhances clarity by explicitly stating the maximum file size, which improves user comprehension.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e450ee9 and eadd834.

Files selected for processing (2)
  • apps/web/public/locales/en/app.json (1 hunks)
  • apps/web/public/locales/hu/app.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • apps/web/public/locales/hu/app.json
Additional comments not posted (1)
apps/web/public/locales/en/app.json (1)

284-285: Approved: New error handling strings added.

The new strings "errorUploadPicture" and "errorUploadPictureDescription" are clear and align well with the rest of the localization file. They enhance user experience by providing specific feedback on upload failures.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between eadd834 and 75ba3ab.

Files selected for processing (1)
  • apps/web/public/locales/nl/app.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/web/public/locales/nl/app.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 75ba3ab and 3c38439.

Files selected for processing (2)
  • apps/web/public/locales/da/app.json (1 hunks)
  • packages/emails/locales/da/emails.json (1 hunks)
Additional comments not posted (2)
packages/emails/locales/da/emails.json (1)

49-49: LGTM!

The new key-value pair "newPoll_preview" has been added correctly to provide the localized preview message when creating a new poll.

apps/web/public/locales/da/app.json (1)

276-285: LGTM!

The new key-value pairs related to profile picture management have been added correctly:

  • "removeAvatar": Localized string for the action to remove the avatar.
  • "uploadProfilePicture": Localized string for the action to upload a profile picture.
  • "profilePictureDescription": Localized description of the profile picture requirements.
  • "invalidFileType": Localized error message for an invalid file type.
  • "invalidFileTypeDescription": Localized description of the allowed file types.
  • "fileTooLarge": Localized error message for a file that is too large.
  • "fileTooLargeDescription": Localized description of the maximum file size.
  • "errorUploadPicture": Localized error message for a generic upload error.
  • "errorUploadPictureDescription": Localized description of the generic upload error.

The changes are approved.

@lukevella lukevella merged commit b75dfed into main Sep 13, 2024
3 checks passed
@lukevella lukevella deleted the l10n_main branch September 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant