Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1176

Merged
merged 6 commits into from
Jun 24, 2024
Merged

🌐 New Crowdin updates #1176

merged 6 commits into from
Jun 24, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jun 21, 2024

Summary by CodeRabbit

  • New Features

    • Added new entries for account management, event hosting, account deletion, and Pro account upgrade prompts in German, French, and Brazilian Portuguese.
    • Included new localization keys for group polls and event management.
  • Removals

    • Removed outdated entries like "createPoll," "comingSoon," "integrations," and "contacts" from German, French, and Brazilian Portuguese locales.
  • Enhancements

    • Updated translations to improve localization consistency across different languages.

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 10:33pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
landing ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2024 10:33pm

Copy link
Contributor

coderabbitai bot commented Jun 21, 2024

Walkthrough

This update primarily focuses on enhancing localization support across various language files, including German, French, and Brazilian Portuguese. Key additions involve new translations related to status, account management, and event handling, while some outdated or redundant entries have been removed to streamline the content.

Changes

Files Change Summary
apps/landing/.../de/common.json Added new "status" key-value pair for German localization.
apps/web/.../de/app.json Removed "verificationCodeSent" and added entries for account management, event hosting, and Pro upgrade prompts.
apps/landing/.../fr/common.json Added new "status" key-value pair for French localization.
apps/web/.../fr/app.json Removed old entries and added new entries for polls, verification, events, and group polls in French.
apps/web/.../pt-BR/app.json Removed old entries and added new entries for polls, events, and group polls in Brazilian Portuguese.

Poem

In code we weave, with language bright,
From German 'status' to French delight,
Portuguese whispers in events that soar,
Enriching user journeys more and more.
In every locale, our app does grow,
A tapestry of languages, a global show.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dffc2ae and 4ed36fb.

Files selected for processing (2)
  • apps/landing/public/locales/de/common.json (1 hunks)
  • apps/web/public/locales/de/app.json (5 hunks)
Files skipped from review due to trivial changes (1)
  • apps/landing/public/locales/de/common.json
Additional comments not posted (9)
apps/web/public/locales/de/app.json (9)

229-229: New localization key for comments.

The addition of the key "commentsDisabled" with the value "Kommentare wurden deaktiviert" is consistent with the application's need to communicate state changes regarding comment functionality to the user.


230-230: New localization key for participant visibility.

The key "allParticipants" is added, likely to enhance UI elements that list or refer to all participants in an event or poll. This is a straightforward addition improving user interface clarity.


232-232: New localization key for no participants.

The addition of "noParticipantsDescription" with the value "Klicke auf Teilen, um Teilnehmer einzuladen" is a user-friendly prompt to guide users in inviting participants when none are present, enhancing the user experience.


233-233: Localization for time zone display.

The key "timeShownIn" added here provides a dynamic way to display the time zone to the user, which is crucial for clarity in applications dealing with multiple time zones.


234-235: New keys for event hosting controls.

The keys "eventHostTitle" and "eventHostDescription" are added to provide clear labels and descriptions for UI elements related to event hosting controls. This helps in managing user expectations and interactions.


236-240: Localization for account deletion functionality.

The series of keys from "deleteAccount" to "deleteAccountInstruction" are crucial for providing localized instructions and warnings to users about the irreversible action of deleting an account. This is important for ensuring that users are fully informed before taking such a significant action.


241-241: Localization for upgrade prompts.

The addition of "upgradePromptTitle" with the value "Auf Pro upgraden" directly supports the application's monetization strategy by encouraging users to consider upgrading to a Pro account.


243-250: New keys for creating and managing polls.

Keys from "create" to "createPoll" provide localized strings for various actions related to creating and managing polls. These additions are essential for user interaction and functionality enhancement.


242-242: Duplicate localization key.

The key "duplicateTitle" appears to be a duplicate of an earlier entry. This needs to be verified if it's intentional or an error.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4ed36fb and 9c534e8.

Files selected for processing (1)
  • apps/web/public/locales/de/app.json (5 hunks)
Additional comments not posted (9)
apps/web/public/locales/de/app.json (9)

266-266: New localization key added: createPoll

The addition of the createPoll key appears to be correctly implemented and is consistent with the application's need to support German localization for creating polls.


232-232: New localization key added: noParticipantsDescription

This key provides a message to encourage users to share the poll to invite participants, which enhances user engagement. The implementation is correct and aligns with the localization objectives.


233-233: New localization key added: timeShownIn

This addition helps clarify the time zone information to the users, which is important for an application managing events across different time zones. The key is implemented correctly.


234-234: New localization key added: pollStatusPausedDescription

This key provides information about the current status of the poll when it's paused, which is crucial for user understanding and interaction with the application. The localization entry is added correctly.


235-235: New localization key added: eventHostTitle

This key is essential for users who are managing events, providing them with a clear label about their role or action they can perform. It is correctly added to the localization file.


236-236: New localization key added: eventHostDescription

This description supports the eventHostTitle by further clarifying the user's capabilities or responsibilities as the event host. It is appropriately localized.


237-244: New localization keys related to account deletion

The keys from deleteAccount to dangerZoneAccount provide detailed steps and warnings about account deletion. These additions are crucial for ensuring that users are fully informed about the irreversible action of deleting an account. The implementation is correct and thorough.


244-246: New localization keys for upgrading to Pro

The upgradePromptTitle and upgradeOverlaySubtitle3 keys are part of the application's strategy to encourage users to upgrade to a Pro plan. These keys are correctly implemented and align with the application's monetization strategy.


246-252: New localization keys for poll finalization and maintenance

The keys from finalizeFeatureDescription to keepPollsIndefinitelyDescription provide users with options and information on finalizing polls and keeping polls indefinitely. These additions enhance the application's functionality and user experience.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9c534e8 and 836459e.

Files selected for processing (2)
  • apps/landing/public/locales/fr/common.json (1 hunks)
  • apps/web/public/locales/fr/app.json (6 hunks)
Files not reviewed due to errors (1)
  • apps/web/public/locales/fr/app.json (no review received)
Files skipped from review due to trivial changes (1)
  • apps/landing/public/locales/fr/common.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 836459e and 7e4c503.

Files selected for processing (1)
  • apps/web/public/locales/pt-BR/app.json (5 hunks)
Additional comments not posted (1)
apps/web/public/locales/pt-BR/app.json (1)

253-266: Ensure consistency and correctness in localization entries.

The newly added localization entries appear correct and consistent with the intended functionality as described in the PR summary. However, make sure these keys are used consistently throughout the application to avoid any missing localization issues.

@lukevella lukevella merged commit 0d589f2 into main Jun 24, 2024
7 checks passed
@lukevella lukevella deleted the l10n_main branch June 24, 2024 07:48
This was referenced Sep 25, 2024
@coderabbitai coderabbitai bot mentioned this pull request Oct 6, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 4, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant