-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 New Crowdin updates #1176
🌐 New Crowdin updates #1176
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
WalkthroughThis update primarily focuses on enhancing localization support across various language files, including German, French, and Brazilian Portuguese. Key additions involve new translations related to status, account management, and event handling, while some outdated or redundant entries have been removed to streamline the content. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/landing/public/locales/de/common.json (1 hunks)
- apps/web/public/locales/de/app.json (5 hunks)
Files skipped from review due to trivial changes (1)
- apps/landing/public/locales/de/common.json
Additional comments not posted (9)
apps/web/public/locales/de/app.json (9)
229-229
: New localization key for comments.The addition of the key "commentsDisabled" with the value "Kommentare wurden deaktiviert" is consistent with the application's need to communicate state changes regarding comment functionality to the user.
230-230
: New localization key for participant visibility.The key "allParticipants" is added, likely to enhance UI elements that list or refer to all participants in an event or poll. This is a straightforward addition improving user interface clarity.
232-232
: New localization key for no participants.The addition of "noParticipantsDescription" with the value "Klicke auf Teilen, um Teilnehmer einzuladen" is a user-friendly prompt to guide users in inviting participants when none are present, enhancing the user experience.
233-233
: Localization for time zone display.The key "timeShownIn" added here provides a dynamic way to display the time zone to the user, which is crucial for clarity in applications dealing with multiple time zones.
234-235
: New keys for event hosting controls.The keys "eventHostTitle" and "eventHostDescription" are added to provide clear labels and descriptions for UI elements related to event hosting controls. This helps in managing user expectations and interactions.
236-240
: Localization for account deletion functionality.The series of keys from "deleteAccount" to "deleteAccountInstruction" are crucial for providing localized instructions and warnings to users about the irreversible action of deleting an account. This is important for ensuring that users are fully informed before taking such a significant action.
241-241
: Localization for upgrade prompts.The addition of "upgradePromptTitle" with the value "Auf Pro upgraden" directly supports the application's monetization strategy by encouraging users to consider upgrading to a Pro account.
243-250
: New keys for creating and managing polls.Keys from "create" to "createPoll" provide localized strings for various actions related to creating and managing polls. These additions are essential for user interaction and functionality enhancement.
242-242
: Duplicate localization key.The key "duplicateTitle" appears to be a duplicate of an earlier entry. This needs to be verified if it's intentional or an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/de/app.json (5 hunks)
Additional comments not posted (9)
apps/web/public/locales/de/app.json (9)
266-266
: New localization key added:createPoll
The addition of the
createPoll
key appears to be correctly implemented and is consistent with the application's need to support German localization for creating polls.
232-232
: New localization key added:noParticipantsDescription
This key provides a message to encourage users to share the poll to invite participants, which enhances user engagement. The implementation is correct and aligns with the localization objectives.
233-233
: New localization key added:timeShownIn
This addition helps clarify the time zone information to the users, which is important for an application managing events across different time zones. The key is implemented correctly.
234-234
: New localization key added:pollStatusPausedDescription
This key provides information about the current status of the poll when it's paused, which is crucial for user understanding and interaction with the application. The localization entry is added correctly.
235-235
: New localization key added:eventHostTitle
This key is essential for users who are managing events, providing them with a clear label about their role or action they can perform. It is correctly added to the localization file.
236-236
: New localization key added:eventHostDescription
This description supports the
eventHostTitle
by further clarifying the user's capabilities or responsibilities as the event host. It is appropriately localized.
237-244
: New localization keys related to account deletionThe keys from
deleteAccount
todangerZoneAccount
provide detailed steps and warnings about account deletion. These additions are crucial for ensuring that users are fully informed about the irreversible action of deleting an account. The implementation is correct and thorough.
244-246
: New localization keys for upgrading to ProThe
upgradePromptTitle
andupgradeOverlaySubtitle3
keys are part of the application's strategy to encourage users to upgrade to a Pro plan. These keys are correctly implemented and align with the application's monetization strategy.
246-252
: New localization keys for poll finalization and maintenanceThe keys from
finalizeFeatureDescription
tokeepPollsIndefinitelyDescription
provide users with options and information on finalizing polls and keeping polls indefinitely. These additions enhance the application's functionality and user experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- apps/landing/public/locales/fr/common.json (1 hunks)
- apps/web/public/locales/fr/app.json (6 hunks)
Files not reviewed due to errors (1)
- apps/web/public/locales/fr/app.json (no review received)
Files skipped from review due to trivial changes (1)
- apps/landing/public/locales/fr/common.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- apps/web/public/locales/pt-BR/app.json (5 hunks)
Additional comments not posted (1)
apps/web/public/locales/pt-BR/app.json (1)
253-266
: Ensure consistency and correctness in localization entries.The newly added localization entries appear correct and consistent with the intended functionality as described in the PR summary. However, make sure these keys are used consistently throughout the application to avoid any missing localization issues.
Summary by CodeRabbit
New Features
Removals
Enhancements