Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1091

Merged
merged 33 commits into from
May 12, 2024
Merged

🌐 New Crowdin updates #1091

merged 33 commits into from
May 12, 2024

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented May 9, 2024

Summary by CodeRabbit

  • New Features
    • Updated text strings and meta information for creating availability and scheduling polls on Rallly platform in Turkish, Spanish, Chinese (Traditional), and Vietnamese.
    • Improved user interface text clarity and consistency in Turkish, Spanish, Chinese (Traditional), and Vietnamese for a better user experience.

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app 🛑 Canceled (Inspect) May 12, 2024 5:47am
landing 🛑 Canceled (Inspect) May 12, 2024 5:47am

Copy link

The latest updates on your projects. Learn more about Tunnel ↗︎

Project Status Link Updated (UTC)
rallly ✅ Ready Visit Dashboard May 9, 2024, 7:54 AM

Copy link
Contributor

coderabbitai bot commented May 9, 2024

Walkthrough

The recent updates across various localization files focus on refining text for clarity, enhancing user interfaces, and expanding descriptions for features related to scheduling and polling on the Rallly platform. These changes aim to improve user experience by providing more intuitive language and additional information across different languages.

Changes

File Path Summary
.../tr/home.json, .../tr/pricing.json Updated text for clarity, added meta descriptions, and detailed poll creation information.
.../ca/app.json, .../es/app.json, .../fr/app.json, .../tr/app.json Removed, updated, and added keys to enhance user interaction and streamline interfaces.

🐰✨
In the land of code and pixel spright,
A rabbit hopped through the night.
Tweaking words with gentle hops,
Making sure the confusion stops.
Now each phrase in its rightful place,
Brings to users a smiling face. 🌟
🐰💬


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bd9e9fe and af5e4c2.
Files selected for processing (2)
  • apps/landing/public/locales/tr/common.json (1 hunks)
  • apps/landing/public/locales/tr/home.json (1 hunks)
Additional comments not posted (7)
apps/landing/public/locales/tr/common.json (2)

21-21: The addition of "freeSchedulingPoll": "Ücretsiz Zamanlama Anketi" is correctly implemented and well-translated.


24-24: The addition of "availabilityPoll": "Uygunluk Anketi" is correctly implemented and well-translated.

apps/landing/public/locales/tr/home.json (5)

18-18: The addition of "doodleAlternativeDescription" is correctly implemented and provides a detailed description, aligning well with the platform's positioning strategy.


19-19: The addition of "availabilityPollCta" is correctly implemented and effectively serves as a clear call-to-action.


20-20: The addition of "availabilityPollMetaTitle" is correctly implemented and is well-suited for SEO and enhancing user understanding.


21-21: The addition of "availabilityPollMetaDescription" is correctly implemented and provides a detailed description that enhances user understanding and SEO.


22-22: The addition of "availabilityPollTitle" is correctly implemented and clearly describes the feature.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between af5e4c2 and 46e3297.
Files selected for processing (1)
  • apps/landing/public/locales/tr/home.json (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/landing/public/locales/tr/home.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 46e3297 and 286e644.
Files selected for processing (3)
  • apps/landing/public/locales/tr/home.json (1 hunks)
  • apps/landing/public/locales/tr/pricing.json (2 hunks)
  • apps/web/public/locales/tr/app.json (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/landing/public/locales/tr/home.json
Additional comments not posted (22)
apps/landing/public/locales/tr/pricing.json (3)

26-26: Good addition of a new key.

The new key "upgradeNowSaveLater" is a valuable addition, providing users with a clear incentive to upgrade their plans early.


27-27: Clear and beneficial description for early adopters.

The "earlyAdopterDescription" key provides a clear benefit for early adopters, locking in subscription fees against future price increases.


29-29: Good addition for feature clarity.

The addition of "keepPollsIndefinitely" is a clear and direct description that enhances user understanding of the benefits of certain plans.

apps/web/public/locales/tr/app.json (19)

206-206: Effective description for early adopters.

The "earlyAdopterDescription" key effectively communicates the benefits of early adoption, which is consistent with similar descriptions in other files.


207-207: Encouraging upgrade incentive.

The "upgradeNowSaveLater" key provides a compelling reason for users to consider upgrading their plans, aligning well with the application's monetization strategy.


219-219: Anticipation building for new features.

The "comingSoon" key is a good addition, building anticipation and keeping users engaged with upcoming features or integrations.


220-220: Introduction of a new key for integrations.

The "integrations" key is a valuable addition, likely related to upcoming features that integrate with other services or platforms.


221-221: Addition of a new key for contacts management.

The "contacts" key suggests new functionality related to managing contacts, which could enhance user interaction and data management within the app.


222-222: Clear incentive for upgrading.

The "unlockFeatures" key clearly communicates the benefits of upgrading to a Pro plan, which is essential for driving conversions.


226-226: Clear status indication.

The "pending" key is a straightforward addition that helps users understand the status of certain actions or processes within the app.


229-229: Useful navigation aid.

The "pageXOfY" key is a useful addition for pagination, helping users understand their location within lists or pages.


230-230: Addressing potential user concerns.

The "noParticipants" key addresses a common scenario in polls and helps manage user expectations.


231-231: Identification for user management.

The "userId" key is crucial for administrative or debugging purposes, allowing for better management and identification of users.


232-232: Clarification for guest users.

The "aboutGuest" key provides necessary information for guest users, clarifying what they can or cannot do within the app.


234-234: Clear logout functionality.

The "logoutDescription" key offers a clear description of the logout process, enhancing user understanding and control over their session.


235-235: Enhancement for event management.

The "events" key suggests enhanced functionality for managing events, which could be a significant feature for users organizing gatherings or meetings.


236-236: Improvement for registration processes.

The "registrations" key indicates improvements or additions to how users can register for events or services, which is crucial for user engagement and data collection.


237-237: Facilitation of participant invitation.

The "inviteParticipantsDescription" key helps clarify the process of inviting participants, making it easier for users to engage others in polls or events.


239-239: Clarification on the use of invitation links.

The "inviteParticipantLinkInfo" key provides essential information on how invitation links function, which is crucial for ensuring proper use and security.


240-240: Handling of account linkage issues.

The "accountNotLinkedTitle" key addresses potential issues users might face when linking accounts, which is important for a smooth user experience.


241-241: Explanation for existing account conflicts.

The "accountNotLinkedDescription" key provides a clear explanation for situations where an email is already associated with an account, helping to prevent confusion and support user account management.


244-244: Automatic timezone adjustments.

The "autoTimeZoneHelp" key explains the benefits of automatic timezone adjustments, which enhances user experience by displaying times in their local timezone.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 286e644 and 15c9c46.
Files selected for processing (2)
  • apps/landing/public/locales/tr/pricing.json (2 hunks)
  • apps/web/public/locales/tr/app.json (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • apps/web/public/locales/tr/app.json
Additional comments not posted (3)
apps/landing/public/locales/tr/pricing.json (3)

25-25: Ensure the translation consistency for "Rallly".

The translation of "Rallly" in the new key "whyUpgradeAnswer2" is inconsistent with other parts of the file where it's referred to as "Rally". Consider using a consistent naming convention across the entire file to avoid confusion.


30-31: Ensure clarity in the description of poll inactivity.

The description in "whenPollInactiveAnswer" could be clearer. It might be beneficial to break down the conditions under which a poll becomes inactive into bullet points or a simpler format to enhance readability and user understanding.


26-26: LGTM! The addition of "upgradeNowSaveLater" effectively communicates the benefits of early upgrading.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 15c9c46 and 7c9f337.
Files selected for processing (1)
  • apps/landing/public/locales/tr/pricing.json (2 hunks)
Additional comments not posted (1)
apps/landing/public/locales/tr/pricing.json (1)

25-27: The explanation for upgrading to a paid plan is clear and effectively communicates the benefits.

"keepPollsIndefinitely": "Anketleri süresiz olarak sakla"
"keepPollsIndefinitely": "Anketleri süresiz olarak sakla",
"whenPollInactive": "Bir anket ne zaman etkisiz hale gelir?",
"whenPollInactiveAnswer": "Anketler, tüm tarih seçenekleri geçmişte kaldığında VE anket 30 günden fazla süredir erişilmediğinde pasif hale gelir. Eğer ücretli bir aboneliğiniz yoksa, pasif hale gelen anketler otomatik olarak silinir."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider enhancing the clarity of the description for when a poll becomes inactive.

- Anketler, tüm tarih seçenekleri geçmişte kaldığında VE anket 30 günden fazla süredir erişilmediğinde pasif hale gelir. Eğer ücretli bir aboneliğiniz yoksa, pasif hale gelen anketler otomatik olarak silinir.
+ Anketler aşağıdaki durumlarda pasif hale gelir:
+ - Tüm tarih seçenekleri geçmişte kaldığında,
+ - Anket 30 günden fazla süredir erişilmediğinde.
+ Eğer ücretli bir aboneliğiniz yoksa, pasif hale gelen anketler otomatik olarak silinir.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"whenPollInactiveAnswer": "Anketler, tüm tarih seçenekleri geçmişte kaldığında VE anket 30 günden fazla süredir erişilmediğinde pasif hale gelir. Eğer ücretli bir aboneliğiniz yoksa, pasif hale gelen anketler otomatik olarak silinir."
"whenPollInactiveAnswer": "Anketler aşağıdaki durumlarda pasif hale gelir:\n- Tüm tarih seçenekleri geçmişte kaldığında,\n- Anket 30 günden fazla süredir erişilmediğinde.\nEğer ücretli bir aboneliğiniz yoksa, pasif hale gelen anketler otomatik olarak silinir."

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7c9f337 and 391b62d.
Files selected for processing (4)
  • apps/web/public/locales/ca/app.json (4 hunks)
  • apps/web/public/locales/es/app.json (5 hunks)
  • apps/web/public/locales/fr/app.json (5 hunks)
  • apps/web/public/locales/tr/app.json (7 hunks)
Files skipped from review due to trivial changes (1)
  • apps/web/public/locales/ca/app.json
Files skipped from review as they are similar to previous changes (1)
  • apps/web/public/locales/tr/app.json
Additional comments not posted (2)
apps/web/public/locales/es/app.json (1)

234-234: Ensure the new key "timeShownIn" integrates well with the existing localization framework.

apps/web/public/locales/fr/app.json (1)

235-236: Verify that the new key "autoTimeZoneHelp" is correctly implemented and that it functions as intended across different user time zones.

Verification successful

The key "autoTimeZoneHelp" is correctly implemented in the French localization file and is used within the application's UI to provide a tooltip explaining its functionality. This tooltip is part of the poll-options-form component, which likely interacts with user settings for time zone adjustments. However, verifying the actual functionality of automatic time zone adjustments would require a deeper inspection of the backend or specific JavaScript/TypeScript functions, which is not covered by the current review.

  • File: apps/web/src/components/forms/poll-options-form/poll-options-form.tsx
  • Usage: Tooltip content explaining the feature to users.
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the implementation of "autoTimeZoneHelp" across different user time zones.

# Test: Search for the function usage. Expect: Correct handling of time zones.
rg --type json $'autoTimeZoneHelp'

Length of output: 2437



Script:

#!/bin/bash
# Description: Search for references to "autoTimeZoneHelp" in the application's source code to verify its functionality.

# Search for the usage of "autoTimeZoneHelp" in JavaScript or TypeScript files.
rg --type js --type ts "autoTimeZoneHelp"

Length of output: 162



Script:

#!/bin/bash
# Description: Examine the usage of "autoTimeZoneHelp" in the specific file to understand its contribution to time zone adjustments.

# Display the relevant code context around the usage of "autoTimeZoneHelp" in the TypeScript file.
rg --type ts --context 10 "autoTimeZoneHelp" apps/web/src/components/forms/poll-options-form/poll-options-form.tsx

Length of output: 1024

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 391b62d and 18b651e.
Files selected for processing (20)
  • apps/web/public/locales/cs/app.json (5 hunks)
  • apps/web/public/locales/da/app.json (5 hunks)
  • apps/web/public/locales/de/app.json (5 hunks)
  • apps/web/public/locales/eu/app.json (5 hunks)
  • apps/web/public/locales/fi/app.json (5 hunks)
  • apps/web/public/locales/hr/app.json (4 hunks)
  • apps/web/public/locales/hu/app.json (5 hunks)
  • apps/web/public/locales/it/app.json (5 hunks)
  • apps/web/public/locales/ko/app.json (3 hunks)
  • apps/web/public/locales/nl/app.json (5 hunks)
  • apps/web/public/locales/no/app.json (5 hunks)
  • apps/web/public/locales/pl/app.json (5 hunks)
  • apps/web/public/locales/pt-BR/app.json (5 hunks)
  • apps/web/public/locales/pt/app.json (1 hunks)
  • apps/web/public/locales/ru/app.json (5 hunks)
  • apps/web/public/locales/sk/app.json (5 hunks)
  • apps/web/public/locales/sv/app.json (5 hunks)
  • apps/web/public/locales/vi/app.json (1 hunks)
  • apps/web/public/locales/zh-Hant/app.json (4 hunks)
  • apps/web/public/locales/zh/app.json (4 hunks)
Files skipped from review due to trivial changes (15)
  • apps/web/public/locales/cs/app.json
  • apps/web/public/locales/de/app.json
  • apps/web/public/locales/eu/app.json
  • apps/web/public/locales/fi/app.json
  • apps/web/public/locales/hu/app.json
  • apps/web/public/locales/it/app.json
  • apps/web/public/locales/ko/app.json
  • apps/web/public/locales/nl/app.json
  • apps/web/public/locales/no/app.json
  • apps/web/public/locales/pl/app.json
  • apps/web/public/locales/pt-BR/app.json
  • apps/web/public/locales/pt/app.json
  • apps/web/public/locales/ru/app.json
  • apps/web/public/locales/vi/app.json
  • apps/web/public/locales/zh/app.json
Additional comments not posted (9)
apps/web/public/locales/zh-Hant/app.json (2)

217-217: The addition of the key "inviteParticipantLinkInfo" is appropriate and enhances the clarity of the invitation process.


218-218: The addition of the key "timeShownIn" is correctly implemented to show the time zone context, which is crucial for scheduling across different regions.

apps/web/public/locales/hr/app.json (2)

184-184: The addition of the key "inviteParticipantLinkInfo" is appropriate and enhances the clarity of the invitation process.


185-185: The addition of the key "timeShownIn" is correctly implemented to show the time zone context, which is crucial for scheduling across different regions.

apps/web/public/locales/sv/app.json (2)

205-205: The addition of the key "or" is correctly implemented and provides necessary conjunction functionality in various contexts.


206-206: The addition of the key "timeShownIn" is correctly implemented to show the time zone context, which is crucial for scheduling across different regions.

apps/web/public/locales/sk/app.json (1)

234-234: Added key "timeShownIn" enhances user experience by providing clear timezone information.

apps/web/public/locales/da/app.json (2)

235-235: Added key "autoTimeZoneHelp" provides useful information about automatic timezone conversion, enhancing user understanding.


236-236: Added key "timeShownIn" maintains consistency across localizations and enhances clarity on timezone information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant