🌐 New Crowdin updates #1491
Merged
🌐 New Crowdin updates #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
WalkthroughThis pull request involves a systematic removal of authentication error messages and pagination strings across multiple language localization files in the web application. Specifically, the changes target the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (25)
apps/web/public/locales/ca/app.json(0 hunks)apps/web/public/locales/cs/app.json(0 hunks)apps/web/public/locales/da/app.json(0 hunks)apps/web/public/locales/de/app.json(0 hunks)apps/web/public/locales/en/app.json(2 hunks)apps/web/public/locales/es/app.json(0 hunks)apps/web/public/locales/eu/app.json(0 hunks)apps/web/public/locales/fi/app.json(0 hunks)apps/web/public/locales/fr/app.json(0 hunks)apps/web/public/locales/hr/app.json(0 hunks)apps/web/public/locales/hu/app.json(0 hunks)apps/web/public/locales/it/app.json(0 hunks)apps/web/public/locales/ja/app.json(0 hunks)apps/web/public/locales/ko/app.json(0 hunks)apps/web/public/locales/nl/app.json(0 hunks)apps/web/public/locales/no/app.json(0 hunks)apps/web/public/locales/pl/app.json(0 hunks)apps/web/public/locales/pt-BR/app.json(0 hunks)apps/web/public/locales/pt/app.json(0 hunks)apps/web/public/locales/ru/app.json(0 hunks)apps/web/public/locales/sk/app.json(0 hunks)apps/web/public/locales/sv/app.json(0 hunks)apps/web/public/locales/tr/app.json(0 hunks)apps/web/public/locales/zh-Hant/app.json(0 hunks)apps/web/public/locales/zh/app.json(0 hunks)
💤 Files with no reviewable changes (24)
- apps/web/public/locales/eu/app.json
- apps/web/public/locales/cs/app.json
- apps/web/public/locales/nl/app.json
- apps/web/public/locales/ja/app.json
- apps/web/public/locales/pt-BR/app.json
- apps/web/public/locales/it/app.json
- apps/web/public/locales/pl/app.json
- apps/web/public/locales/fi/app.json
- apps/web/public/locales/zh-Hant/app.json
- apps/web/public/locales/ca/app.json
- apps/web/public/locales/de/app.json
- apps/web/public/locales/ru/app.json
- apps/web/public/locales/tr/app.json
- apps/web/public/locales/hu/app.json
- apps/web/public/locales/pt/app.json
- apps/web/public/locales/hr/app.json
- apps/web/public/locales/ko/app.json
- apps/web/public/locales/no/app.json
- apps/web/public/locales/zh/app.json
- apps/web/public/locales/es/app.json
- apps/web/public/locales/da/app.json
- apps/web/public/locales/sk/app.json
- apps/web/public/locales/sv/app.json
- apps/web/public/locales/fr/app.json
🔇 Additional comments (1)
apps/web/public/locales/en/app.json (1)
284-284: LGTM! Clear cancellation message with proper link.The message provides clear information about cancellation and properly uses HTML tags for the billing page link.
apps/web/public/locales/en/app.json
Outdated
Comment on lines
201
to
210
| "authErrorTitle": "Login Error", | ||
| "authErrorDescription": "There was an error logging you in. Please try again.", | ||
| "authErrorCta": "Go to login page", | ||
| "continueAs": "Continue as", | ||
| "pageMovedDescription": "Redirecting to <a>{newUrl}</a>", | ||
| "notRegistered": "Don't have an account? <a>Register</a>", | ||
| "unlockFeatures": "Unlock all Pro features.", | ||
| "pollStatusFinalized": "Finalized", | ||
| "share": "Share", | ||
| "pageXOfY": "Page {currentPage} of {pageCount}", |
There was a problem hiding this comment.
💡 Codebase verification
Missing implementations and translations for new locale strings
These newly added strings appear to have potential integration issues:
- No usage found in the source code for auth error messages (
authErrorTitle,authErrorDescription,authErrorCta) - No usage found for the pagination string (
pageXOfY) - Missing translations in other language files
- These strings might be for a feature in development, but ensure they're properly implemented and translated before release
🔗 Analysis chain
Verify the integration of these strings in the codebase.
Let's ensure these new strings are properly integrated and used in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the usage of the new localization strings in the codebase
# Search for auth error string usage
echo "Checking auth error string usage..."
rg -l "authErrorTitle|authErrorDescription|authErrorCta" --type ts --type tsx
# Search for pagination string usage
echo "Checking pagination string usage..."
rg -l "pageXOfY" --type ts --type tsx
# Check if these strings exist in other language files
echo "Checking other language files..."
fd -e json -e yaml . apps/web/public/locales -x grep -l "authErrorTitle\|pageXOfY" {} \;
Length of output: 540
Script:
#!/bin/bash
# Search with correct typescript/react file extensions
echo "Checking component usage of auth strings..."
rg "('|\")authError(Title|Description|Cta)('|\")" -t ts -t tsx -t jsx -t js
echo "Checking component usage of pagination..."
rg "('|\")pageXOfY('|\")" -t ts -t tsx -t jsx -t js
echo "Checking translation function usage..."
rg "t\(['\"]authError|t\(['\"]pageXOfY" -t ts -t tsx -t jsx -t js
echo "Checking all language files..."
fd . apps/web/public/locales -e json -x cat {} \; | grep -A 1 "authError\|pageXOfY"
Length of output: 1011
Script:
#!/bin/bash
echo "Searching for auth error strings in source files..."
find . -type f \( -name "*.tsx" -o -name "*.ts" -o -name "*.jsx" -o -name "*.js" \) -not -path "*/node_modules/*" -not -path "*/dist/*" -exec grep -l "authError\|t('authError\|t(\"authError" {} \;
echo "Searching for pagination string usage..."
find . -type f \( -name "*.tsx" -o -name "*.ts" -o -name "*.jsx" -o -name "*.js" \) -not -path "*/node_modules/*" -not -path "*/dist/*" -exec grep -l "pageXOfY\|t('pageXOfY\|t(\"pageXOfY" {} \;
echo "Checking other language files for translations..."
find apps/web/public/locales -type f -name "*.json" -not -name "en.json" -exec grep -l "authError\|pageXOfY" {} \;
Length of output: 875
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
[ci skip]
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/public/locales/en/app.json (1)
283-292: Consider standardizing error message patterns.While the email change flow strings are comprehensive, consider standardizing error messages to match existing patterns in the codebase:
emailChangeFailedis terse compared to other error messages that provide more contextemailChangeErroris generic and could be more specificConsider these improvements:
- "emailChangeFailed": "Email change failed", + "emailChangeFailed": "Unable to change email address. Please try again.", - "emailChangeError": "An error occurred while changing your email", + "emailChangeError": "There was a problem updating your email address. Please try again later.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/public/locales/en/app.json(1 hunks)packages/emails/locales/en/emails.json(1 hunks)
🔇 Additional comments (2)
packages/emails/locales/en/emails.json (1)
50-56: LGTM! Email change verification flow is well-structured.The email change verification flow strings are complete and follow best practices:
- Clear subject and preview text for email clients
- Proper use of HTML formatting tags
- Informative text with proper placeholders
- Security-conscious with expiration warning and support contact
apps/web/public/locales/en/app.json (1)
282-282: LGTM! Unsubscribe notification message is clear and concise.The message follows the existing pattern for notification messages.
Comment on lines
+283
to
+292
| "emailChangeSuccess": "Email changed successfully", | ||
| "emailChangeSuccessDescription": "Your email has been updated", | ||
| "emailChangeFailed": "Email change failed", | ||
| "emailChangeInvalidToken": "The verification link is invalid or has expired. Please try again.", | ||
| "emailChangeError": "An error occurred while changing your email", | ||
| "emailChangeRequestSent": "Verify your new email address", | ||
| "emailChangeRequestSentDescription": "To complete the change, please check your email for a verification link.", | ||
| "profileEmailAddress": "Email Address", | ||
| "profileEmailAddressDescription": "Your email address is used to log in to your account", | ||
| "emailAlreadyInUse": "Email already in use. Please try a different one or delete the existing account." |
There was a problem hiding this comment.
💡 Codebase verification
Email change translations added without implementation
These translation strings appear to be added prematurely as there is no corresponding implementation in the codebase:
- No components or hooks using these translation keys
- No test files referencing email change functionality
- No translations added in other language files
Please ensure this is intentional and part of upcoming work. If not, consider removing these unused translations until the implementation is ready.
🔗 Analysis chain
Verify implementation of email change flow.
Let's ensure these new email change strings are properly integrated in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check the usage of email change strings in the codebase
echo "Checking email change string usage in components..."
rg "('|\")emailChange(Success|Failed|Error|InvalidToken|RequestSent)('|\")" -t ts -t tsx
echo "Checking translation function usage..."
rg "t\(['\"]emailChange" -t ts -t tsx
echo "Checking other language files for translations..."
fd . apps/web/public/locales -e json -not -path "*en*" -x grep -l "emailChange" {} \;
Length of output: 821
Script:
#!/bin/bash
# Search for email change related translation keys usage
echo "=== Checking email change translations usage ==="
rg "emailChange" --type=typescript --type=tsx
echo -e "\n=== Checking other language files ==="
# First find json files
fd -e json . apps/web/public/locales | grep -v "/en/" | while read -r file; do
echo "Checking $file"
grep "emailChange" "$file" || true
done
echo -e "\n=== Checking components and hooks ==="
# Look for potential email change related components/hooks
rg -l "email.*change|change.*email" --type=typescript --type=tsx
Length of output: 5668
Script:
#!/bin/bash
echo "=== Checking email change implementation ==="
# Search in ts/tsx files using extensions
rg "emailChange" -g "*.ts" -g "*.tsx"
echo -e "\n=== Checking test files ==="
# Look specifically in test files
rg "emailChange" -g "*test.ts" -g "*test.tsx" -g "*spec.ts" -g "*spec.tsx"
echo -e "\n=== Checking translation usage patterns ==="
# Look for common translation usage patterns
rg "t\(['\"]emailChange|useTranslation.*emailChange|i18n.*emailChange" -g "*.ts" -g "*.tsx"
echo -e "\n=== Checking for email change related components ==="
# Find potential email change related files
find . -type f \( -name "*.ts" -o -name "*.tsx" \) -exec grep -l "email.*change\|change.*email" {} \;
Length of output: 711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit