🐛 fix: fix agent config not load correctly #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:M
|
👍 @arvinxx Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6252 +/- ##
=========================================
Coverage 91.69% 91.69%
=========================================
Files 681 681
Lines 62113 62120 +7
Branches 4490 3084 -1406
=========================================
+ Hits 56954 56964 +10
+ Misses 5159 5156 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arvinxx
changed the title
dosubot
bot
added
size:L
TestGru AssignmentSummary
Files
Tip You can |
TestGru AssignmentSummary
Files
Tip You can |
|
❤️ Great PR @arvinxx ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
### [Version 1.60.4](v1.60.3...v1.60.4) <sup>Released on **2025-02-17**</sup> #### 🐛 Bug Fixes - **misc**: Fix agent config not load correctly. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix agent config not load correctly, closes [#6252](#6252) ([fe9bc16](fe9bc16)) </details> <div align="right"> [](#readme-top) </div>
|
🎉 This PR is included in version 1.60.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to bentwnghk/lobe-chat
that referenced
this pull request
Feb 17, 2025
## [Version 1.101.0](v1.100.0...v1.101.0) <sup>Released on **2025-02-17**</sup> #### ✨ Features - **misc**: Add SambaNova provider support, add volcengine as a new provider. #### 🐛 Bug Fixes - **misc**: Fix agent config not load correctly, fix loading on not login for db, fix model list issue in client mode, user feedback for empty/long group names in create/edit group modals. #### 💄 Styles - **misc**: Add o1 vision metadata, update Jina AI Provider name & model info. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add SambaNova provider support, closes [lobehub#6218](https://github.com/bentwnghk/lobe-chat/issues/6218) ([a46eadf](a46eadf)) * **misc**: Add volcengine as a new provider, closes [lobehub#6221](https://github.com/bentwnghk/lobe-chat/issues/6221) ([09bf8f0](09bf8f0)) #### What's fixed * **misc**: Fix agent config not load correctly, closes [lobehub#6252](https://github.com/bentwnghk/lobe-chat/issues/6252) ([fe9bc16](fe9bc16)) * **misc**: Fix loading on not login for db, closes [lobehub#6258](https://github.com/bentwnghk/lobe-chat/issues/6258) ([61692b9](61692b9)) * **misc**: Fix model list issue in client mode, closes [lobehub#6240](https://github.com/bentwnghk/lobe-chat/issues/6240) ([d6c6cda](d6c6cda)) * **misc**: User feedback for empty/long group names in create/edit group modals, closes [lobehub#6247](https://github.com/bentwnghk/lobe-chat/issues/6247) ([25c80d1](25c80d1)) #### Styles * **misc**: Add o1 vision metadata, closes [lobehub#6263](https://github.com/bentwnghk/lobe-chat/issues/6263) ([261d068](261d068)) * **misc**: Update Jina AI Provider name & model info, closes [lobehub#6243](https://github.com/bentwnghk/lobe-chat/issues/6243) ([ddbe482](ddbe482)) </details> <div align="right"> [](#readme-top) </div>
likaiqiang
pushed a commit
to likaiqiang/lobe-chat
that referenced
this pull request
Feb 26, 2025
* fix agent config issue * improve loading for agent * revert chat change
likaiqiang
pushed a commit
to likaiqiang/lobe-chat
that referenced
this pull request
Feb 26, 2025
### [Version 1.60.4](lobehub/lobe-chat@v1.60.3...v1.60.4) <sup>Released on **2025-02-17**</sup> #### 🐛 Bug Fixes - **misc**: Fix agent config not load correctly. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fix agent config not load correctly, closes [lobehub#6252](lobehub#6252) ([fe9bc16](lobehub@fe9bc16)) </details> <div align="right"> [](#readme-top) </div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
这一版应该修好了
📝 补充信息 | Additional Information
最终发现是由于 fetchAgentConfig 没有依赖 isLogin ，导致请求的时序匹配不上。当用户状态没有置于登录态时，请求 agentConfig 在之前的实现中兜底到了
DEFAULT_AGENT_CONFIG。这个应该是 db 版第一次实现时遗留的一个隐形 bug。由于静态化之后，页面速度打开加快，速度超过了登录态的获取，因此在之前发起请求时应用其实仍然处于未登录。而切换页面状态（例如 #6123 (comment) 提到的）就可以用登录态重新请求，拿到的数据也是对的。