🐛 fix: user feedback for empty/long group names in create/edit group …

…modals (lobehub#6247)
bentwnghk · Feb 17, 2025 · 25c80d1 · 25c80d1
1 parent 32f442d
commit 25c80d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...p/[variants]/(main)/chat/@session/features/SessionListContent/Modals/CreateGroupModal.tsx b/...p/[variants]/(main)/chat/@session/features/SessionListContent/Modals/CreateGroupModal.tsx
@@ -35,8 +35,6 @@ const CreateGroupModal = memo<CreateGroupModalProps>(
             onCancel?.(e);
           }}
           onOk={async (e: MouseEvent<HTMLButtonElement>) => {
-            if (!input) return;
-
             if (input.length === 0 || input.length > 20)
               return message.warning(t('sessionGroup.tooLong'));
 

diff --git a/...p/[variants]/(main)/chat/@session/features/SessionListContent/Modals/RenameGroupModal.tsx b/...p/[variants]/(main)/chat/@session/features/SessionListContent/Modals/RenameGroupModal.tsx
@@ -17,13 +17,13 @@ const RenameGroupModal = memo<RenameGroupModalProps>(({ id, open, onCancel }) =>
   const updateSessionGroupName = useSessionStore((s) => s.updateSessionGroupName);
   const group = useSessionStore((s) => sessionGroupSelectors.getGroupById(id)(s), isEqual);
 
-  const [input, setInput] = useState<string>();
+  const [input, setInput] = useState<string>('');
   const [loading, setLoading] = useState(false);
 
   const { message } = App.useApp();
 
   useEffect(() => {
-    setInput(group?.name);
+    setInput(group?.name ?? '');
   }, [group]);
 
   return (
@@ -32,11 +32,10 @@ const RenameGroupModal = memo<RenameGroupModalProps>(({ id, open, onCancel }) =>
       destroyOnClose
       okButtonProps={{ loading }}
       onCancel={(e) => {
-        setInput(group?.name);
+        setInput(group?.name ?? '');
         onCancel?.(e);
       }}
       onOk={async (e) => {
-        if (!input) return;
         if (input.length === 0 || input.length > 20)
           return message.warning(t('sessionGroup.tooLong'));
         setLoading(true);