-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: user feedback for empty/long group names in create/edit group modals #6247
Conversation
@ramu-narasinga is attempting to deploy a commit to the LobeHub Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6247 +/- ##
========================================
Coverage 91.69% 91.69%
========================================
Files 681 681
Lines 62025 62113 +88
Branches 4288 4489 +201
========================================
+ Hits 56872 56954 +82
- Misses 5153 5159 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❤️ Great PR @ramu-narasinga ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 1.60.3](v1.60.2...v1.60.3) <sup>Released on **2025-02-17**</sup> #### 🐛 Bug Fixes - **misc**: User feedback for empty/long group names in create/edit group modals. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: User feedback for empty/long group names in create/edit group modals, closes [#6247](#6247) ([25c80d1](25c80d1)) </details> <div align="right"> [](#readme-top) </div>
🎉 This PR is included in version 1.60.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [Version 1.101.0](v1.100.0...v1.101.0) <sup>Released on **2025-02-17**</sup> #### ✨ Features - **misc**: Add SambaNova provider support, add volcengine as a new provider. #### 🐛 Bug Fixes - **misc**: Fix agent config not load correctly, fix loading on not login for db, fix model list issue in client mode, user feedback for empty/long group names in create/edit group modals. #### 💄 Styles - **misc**: Add o1 vision metadata, update Jina AI Provider name & model info. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Add SambaNova provider support, closes [lobehub#6218](https://github.com/bentwnghk/lobe-chat/issues/6218) ([a46eadf](a46eadf)) * **misc**: Add volcengine as a new provider, closes [lobehub#6221](https://github.com/bentwnghk/lobe-chat/issues/6221) ([09bf8f0](09bf8f0)) #### What's fixed * **misc**: Fix agent config not load correctly, closes [lobehub#6252](https://github.com/bentwnghk/lobe-chat/issues/6252) ([fe9bc16](fe9bc16)) * **misc**: Fix loading on not login for db, closes [lobehub#6258](https://github.com/bentwnghk/lobe-chat/issues/6258) ([61692b9](61692b9)) * **misc**: Fix model list issue in client mode, closes [lobehub#6240](https://github.com/bentwnghk/lobe-chat/issues/6240) ([d6c6cda](d6c6cda)) * **misc**: User feedback for empty/long group names in create/edit group modals, closes [lobehub#6247](https://github.com/bentwnghk/lobe-chat/issues/6247) ([25c80d1](25c80d1)) #### Styles * **misc**: Add o1 vision metadata, closes [lobehub#6263](https://github.com/bentwnghk/lobe-chat/issues/6263) ([261d068](261d068)) * **misc**: Update Jina AI Provider name & model info, closes [lobehub#6243](https://github.com/bentwnghk/lobe-chat/issues/6243) ([ddbe482](ddbe482)) </details> <div align="right"> [](#readme-top) </div>
### [Version 1.60.3](lobehub/lobe-chat@v1.60.2...v1.60.3) <sup>Released on **2025-02-17**</sup> #### 🐛 Bug Fixes - **misc**: User feedback for empty/long group names in create/edit group modals. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: User feedback for empty/long group names in create/edit group modals, closes [lobehub#6247](lobehub#6247) ([25c80d1](lobehub@25c80d1)) </details> <div align="right"> [](#readme-top) </div>
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
To show an alert when the user submits an empty or long group name in Create Group and Rename Group Modals.
📝 补充信息 | Additional Information
if
block in CreateModalTo allow the input length check that shows an alert if the title does not meet the criteria.
if
block in RenameGroupModalTo allow the input length check that shows an alert if the title does not meet the criteria.
2.1 And this forced to ensure types are valid for
input
state variable, as a resultinput
state is initialized to '' (empty string - following the same convention in CreateGroupModal)2.2 Added fallback to empty string in the
onCancel
, in case the group.name is empty.