Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release)!: Version 3.0 #3364

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

chore(release)!: Version 3.0 #3364

wants to merge 34 commits into from

Conversation

JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Apr 10, 2024 •
edited
Loading

Standing PR for the 3.0 release

Important

  • Until feature freeze in 2.x, be mindful of the changes you are pulling into this branch.
  • Use rebasing to bring the latest changes from main into this branch as it makes the process of merging it back into main with a merge commit when the release is due easier
  • Use a merge commit without squashing when merging this branch into main to keep the history of the feature commits intact

Breaking Changes

Any breaking changes should be properly marked with ! in the conventional commits schema, e.g., fix($scope)!: fix thing but it broke stuff, feat(dtos)!: add breaking feature

@JacobCoffee JacobCoffee requested review from provinzkraut and a team as code owners April 10, 2024 07:00
@JacobCoffee JacobCoffee added the do not merge Don't merge this label Apr 10, 2024
@github-actions github-actions bot added area/ci This PR involves changes to the CI/Infra area/dependencies This PR involves changes to the dependencies area/docs This PR involves changes to the documentation size: medium pr/internal labels Apr 10, 2024
@JacobCoffee JacobCoffee marked this pull request as draft April 10, 2024 07:02
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.48693% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.26%. Comparing base (356cf0a) to head (33071ed).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
litestar/handlers/base.py 95.34% 4 Missing and 2 partials ⚠️
litestar/handlers/http_handlers/_utils.py 66.66% 3 Missing ⚠️
litestar/app.py 98.66% 0 Missing and 1 partial ⚠️
...estar/handlers/websocket_handlers/route_handler.py 97.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3364      +/-   ##
==========================================
- Coverage   98.35%   98.26%   -0.09%     
==========================================
  Files         347      342       -5     
  Lines       15783    15390     -393     
  Branches     1745     1667      -78     
==========================================
- Hits        15523    15123     -400     
- Misses        124      133       +9     
+ Partials      136      134       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added area/connection area/contrib This PR involves changes to the contrib (Deprecated) area/handlers This PR involves changes to the handlers area/middleware This PR involves changes to the middleware area/private-api This PR involves changes to the privatized API area/static-files area/template area/testing size: large and removed size: medium labels Apr 10, 2024
provinzkraut and others added 27 commits February 16, 2025 16:23
@provinzkraut @JacobCoffee @peterschutt
refactor(routing)!: Refactor routes and route handlers (#3386)
f407513 
* remove handler names
* Remove option handler creation from HTTPRoute
* Remove methods attribute from BaseRoute
* Move kwargs model to handlers and creation to on_registration
* Store kwargs model on handlers instead of routes
* Simplify HTTPRoute route_handler_map creation
* Simplify Router.route_handler_method_map
* Relax typing of HTTPRoute
* Move handling logic to route handlers
* Remove scope_type
* Don't pass route to HTTPRouteHandler during handling
* Don't pass scope to handle methods
* Resolve and establish connections in routes; Only pass connections to handlers

---------

Co-authored-by: Jacob Coffee <[email protected]>
Co-authored-by: Peter Schutt <[email protected]>
@JacobCoffee @provinzkraut
docs!: update to v3 style (#3324) (#3432)
c44e184 
fix(docs): adjust build script
@provinzkraut
Fix rebase issue
b23eeb3
@provinzkraut
Resolve merge conflicts
e86be7d
@provinzkraut
fix: Port CVE-2024-32982 path traversal fix to v3.0 (#3524)
87b7082 
* Backport static files path traversal fix
@provinzkraut
feat!: Make route handlers functional decorators (#3436)
a6da7de 
* make route handlers functional decorators
@provinzkraut
Fix merge artifact
f4a5c13
@provinzkraut
test: Remove test for warnings when subclassing route handler decorat…
adf7049 
…ors (#3529)

Remove deprecated test
@provinzkraut
fix merge artifacts
dd4455d
@provinzkraut
fix(typing): "Fix" typing for Controller.as_router (#3571)
f7fbf4b 
ignore type error
@provinzkraut
feat!: Remove deprecated litestar.middleware.exceptions module and …
cc0a7b6 
…deprecated params of internal `ExceptionHandlerMiddleware` (#3435)

* refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (#3393)
* Remove 'app' parameter from `.to_asgi_response`
* Remove debug param
* Remove exception_handlers param
* Remove litestar.middleware.exceptions
@jderrien @provinzkraut
feat(logging): always log exceptions by default (#3574)
5e8090e
@provinzkraut
chore: Port fix for #3593 to v3 (#3638)
ca4dc36 
Port parse_values_from_connection_kwargs changes
@provinzkraut
resolve http handler conflicts
32ffd50
@provinzkraut
formatting
419a097
@provinzkraut
feat: Update MessagPack media type (#3732)
48a9015
@provinzkraut
Fix conflicts
b0f0d35
@provinzkraut
fix conflicts
21510d1
@provinzkraut
conflict resolution
76981b2
@provinzkraut
fix conflict
89924bd
@provinzkraut
fix ws streaming
e8895ea
@JacobCoffee @provinzkraut
docs: fix wording
52ded8b
@JacobCoffee @provinzkraut
docs: fix caption
57dc499
@provinzkraut
fix dependency issue
648dbfd
@provinzkraut
formatting
b1ee95d
@provinzkraut
typing fixes
349bf3c
@provinzkraut
feat!: static handler configuration (#3900)
dbf055e
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Major Issues (required ≤ 2)
10 New Code Smells (required ≤ 3)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provinzkraut provinzkraut Awaiting requested review from provinzkraut provinzkraut is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/asgi area/channels area/connection area/constants This PR involves changes to the constants area/contrib This PR involves changes to the contrib (Deprecated) area/controller area/dependencies This PR involves changes to the dependencies area/di area/docs This PR involves changes to the documentation area/dto This PR involves changes to the DTOs area/enums This PR involves changes to the enums area/handlers This PR involves changes to the handlers area/kwargs area/layers area/logging area/middleware This PR involves changes to the middleware area/openapi This PR involves changes to the OpenAPI schema area/private-api This PR involves changes to the privatized API area/response area/router area/static-files area/template area/testing area/types This PR involves changes to the custom types do not merge Don't merge this pr/internal size: large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JacobCoffee @provinzkraut @peterschutt @jderrien