-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove deprecated app
param of Response.to_asgi_response
#3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c10e08
to
5824bf4
Compare
peterschutt
approved these changes
Apr 15, 2024
provinzkraut
commented
Apr 15, 2024
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3393 |
provinzkraut
added a commit
that referenced
this pull request
Apr 20, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Apr 21, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Apr 27, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Apr 27, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Apr 28, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
May 25, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
May 26, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jun 15, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jun 15, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jun 15, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jun 16, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jun 21, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Sep 14, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Sep 15, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Sep 15, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Sep 21, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Sep 23, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Nov 24, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Nov 24, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Nov 28, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Nov 29, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Dec 12, 2024
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Jan 28, 2025
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Feb 14, 2025
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
provinzkraut
added a commit
that referenced
this pull request
Feb 16, 2025
…e` (#3393) * Remove 'app' parameter from `.to_asgi_response`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated
app
parameter ofResponse.to_asgi_response
; Its usage has been replaced internally byrequest.app
, and custom response classes can follow the same pattern.