-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Make route handlers functional decorators #3436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.0 #3436 +/- ##
=======================================
Coverage 97.98% 97.99%
=======================================
Files 326 326
Lines 14566 14559 -7
Branches 2314 2306 -8
=======================================
- Hits 14273 14267 -6
Misses 154 154
+ Partials 139 138 -1 ☔ View full report in Codecov by Sentry. |
98bf1ab
to
48ab468
Compare
provinzkraut
added a commit
that referenced
this pull request
Nov 29, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Dec 12, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Dec 13, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Dec 13, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Dec 13, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Dec 13, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Dec 13, 2024
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 11, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 15, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Jan 28, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Feb 14, 2025
* make route handlers functional decorators
provinzkraut
added a commit
that referenced
this pull request
Feb 16, 2025
* make route handlers functional decorators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/channels
area/controller
area/docs
This PR involves changes to the documentation
area/handlers
This PR involves changes to the handlers
area/private-api
This PR involves changes to the privatized API
area/testing
area/types
This PR involves changes to the custom types
Breaking 🔨
pr/internal
size: large
type/feat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make route handler decorators functional decorators.
This gets rids of the
__call__
method having to mutate internal state and lets us clean up things a bit.It also makes for a nicer syntax and improved type/runtime checking of the handler classes, because they can now receive a
fn
as a required keyword argument, which gets rid of theHandlerClass("/")(handler_fn)
pattern.