Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: shapella upgrade from rc.0 to rc.1 [WIP] #709

Merged
merged 97 commits into from
Apr 4, 2023
Merged

Feat: shapella upgrade from rc.0 to rc.1 [WIP] #709

merged 97 commits into from
Apr 4, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Mar 28, 2023 •
edited
Loading

TheDZhon and others added 30 commits March 26, 2023 20:59
@TheDZhon
fix: make isLimitReached more coherent
02cb05f
@TheDZhon
ci: remove abi linter
2b071f2
@skozin
hash consensus: fix fast lane members calc when quorum > num members
e735080
@loga4
remove unused Math256.abs() func
29efd7f
@skozin
tests (accounting oracle): get rid of a misleading helper
d86ce49
@skozin
accounting oracle: fix check enforcing extra data submission order
8488ee9
@skozin
fix: check the EIP-1271 call result more strictly
2dbad61 
Make sure that 1) the returned data size is exactly 32 bytes; 2) only the first 4 bytes are non-zero; 3) these 4 bytes contain the magic value

This doesn't support contracts right-padding the magic value with zeroes to a size longer than 32 bytes, like the Solidity ABI decoder allows, but that's a really exotic edge-case
@Psirex
Add missing nonce changes to NodeOperatorsRegistry
26844cf
@skozin
hash consensus: check the chain config is valid
9472512
@skozin
hash consensus: improve code clarity around report processing deadline
b91ad87
@loga4
remove bytes conversation
0a9dbcb
@skozin
hash consensus: remove an unnecessary function
c366355
@skozin
DSM: docs and naming fixes
b209c08
@skozin
accounting oracle: clarify a comment
c5ba9ab
@arwer13
fix: Lido.getFeeDistribution must return values relative to total fee
cdd3747
@arwer13
fix: typos in StakingRouter comments
5cc268e
@skozin
tests: add a missing visibility modifier
5a10882
@skozin
oracle: don't accept a report hash if the deadline is already missed
cae86db 
this doesn't affect correctness (since one won't be able to submit data for such a report anyway) but should help in troubleshooting
@skozin
exit bus oracle: remove an unused return value
7a93c4a
@skozin
hash consensus: minor gas optimizations
39b2242
@Psirex
Make clearNodeOperatorPenalty external
6f37ff5
@Psirex
Update arrays trim logic in the getStakingRewardsDistribution
48e3a54
@Psirex
Remove payable modifier for request.owner in the _transfer
1e17bad
@Psirex
Fix keysCount and startIndex check in saveKeysSigs
f7680b1
@Psirex
Check maxPositiveTokenRebase not equal to zero
df51ab0
@krogla
fix: check stuck+exited<=deposited
e4d0bf7
@krogla
fix: exited/stuck check for UIN64_MAX
662d47a
@krogla
fix: remove int64 limitations
b1532ef
@TheDZhon
Merge pull request #713 from lidofinance/fix/mixbytes_audit
a0ea670 
Fix/mixbytes audit
@TheDZhon
Merge pull request #711 from lidofinance/fix/hash-consnesus-fast-lane…
360585f 
…-calc

Fix: HashConsensus fast lane calc when consensus is disabled
loga4 and others added 22 commits April 4, 2023 01:38
@loga4
restrict name size to 31 bytes
d1facbd
@loga4
remove double check on resume pause
2032f0d
@loga4
add active check to onlyNodeOperatorManager
62d19d7
@loga4
fix typos
9f8eb2e
@loga4
add override keyword for name
2f5f5f6
@loga4
fix tests
68b57ba
@loga4
fix linter
36cb236
@TheDZhon
Merge pull request #724 from lidofinance/fix/check-zero-admin-orsc
d1f5451 
Fix: check zero admin in OracleReportSanityChecker constructor
@TheDZhon
Merge remote-tracking branch 'origin/fix/shapella-upgrade-from-rc0-to…
67b8894 
…-rc1' into fix/typos
@TheDZhon
Merge pull request #728 from lidofinance/fix/typos
630fc53 
Fix: typos
@TheDZhon
chore: e4 precision helper
b1423db
@TheDZhon
Merge pull request #725 from lidofinance/fix/staking-module-length
7ceed77 
Fix: restrict staking module name length to 31 bytes
@TheDZhon
test: make nonce test more expressive
257b306
@TheDZhon
chore: typos
81745ff
@TheDZhon
Merge pull request #727 from lidofinance/fix/check-nor-nonce
0628547 
Fix: check nor active status
@TheDZhon
Merge pull request #726 from lidofinance/fix/resume-pause-double-check
afa0765 
Fix: resume pause double check
@Psirex
Fix naming for validators' totals in getNodeOperator
3410a8a
@Psirex
Merge branch 'fix/shapella-upgrade-from-rc0-to-rc1' of github.com:lid…
296bc4d 
…ofinance/lido-dao into fix/nor-int64-math
@TheDZhon
Merge pull request #719 from lidofinance/fix/nor-int64-math
847d23c 
fix: remove int64 limitations
@krogla
fix: add _mintInitialShares
7e4b969
@Psirex
Add requirement comments for IStakingModule
4c80206
@TheDZhon
Merge pull request #722 from lidofinance/fix/transfer-events-order
e4f556c 
transfer events order
@TheDZhon TheDZhon marked this pull request as ready for review April 4, 2023 16:05
@TheDZhon TheDZhon merged commit feafec4 into feature/shapella-upgrade Apr 4, 2023
@TheDZhon TheDZhon deleted the fix/shapella-upgrade-from-rc0-to-rc1 branch April 4, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TheDZhon @skozin @loga4 @Psirex @arwer13 @krogla @Jeday