Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/lido fee distribution #717

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Fix/lido fee distribution #717

merged 2 commits into from
Mar 30, 2023

Conversation

arwer13
Copy link
Contributor

@arwer13 arwer13 commented Mar 29, 2023

To keep backward compatibility Lido.getFeeDistribution must return fee values relative to the total protocol fee (result of Lido.getFee(). Before the fix it returned absolute values the same way as StakingRouter.getStakingFeeAggregateDistributionE4Precision() does

@TheDZhon TheDZhon mentioned this pull request Mar 30, 2023
Merged
23 tasks
TheDZhon
TheDZhon approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheDZhon TheDZhon merged commit fc750ab into fix/shapella-upgrade-from-rc0-to-rc1 Mar 30, 2023
@TheDZhon TheDZhon deleted the fix/lido-fee-distribution branch March 30, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arwer13 @TheDZhon