Fix reward distribution algorithm #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 14, 2020
…accumulation on the NodeOperatorRegistry
skozin
force-pushed
the
distribute-rewards-fix
branch
from
6d718fe to
dd31946
Compare
3 tasks
skozin
approved these changes
Dec 14, 2020
This was referenced Dec 14, 2020
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this pull request
Jan 26, 2021
…s-fix Fix reward distribution algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors node operators’ reward distribution mechanics. Previously,
NodeOperatorsRegistrydistributed token rewards between operators on its own. Now,Lidogets a list of reward amounts and the corresponding operator addresses fromNodeOperatorRegistryand performs transfers by itself. In the case of registering a profit without any active node operators, the new algorithm transfers all operators' fee tokens to the treasury. This approach is more gas efficient and prevents accumulatingStETHdust on any contract involved.Fix #237
Fix #241
Fix #240