Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Values in events generated by submit and fallback function are incorrect #240

Closed
kadmil opened this issue Dec 13, 2020 · 1 comment · Fixed by #236
Closed

Values in events generated by submit and fallback function are incorrect #240

kadmil opened this issue Dec 13, 2020 · 1 comment · Fixed by #236

Comments

@kadmil
Copy link
Contributor

kadmil commented Dec 13, 2020

Due to the order of operations in _submit method in Lido.sol the value field in generated Transfer event is calculated incorrectly
@kadmil kadmil mentioned this issue Dec 13, 2020
Merged
@ujenjt ujenjt mentioned this issue Dec 14, 2020
Closed
3 tasks
@skozin skozin linked a pull request Dec 14, 2020 that will close this issue
Fix reward distribution algorithm #236
Merged
@skozin
Copy link
Member

skozin commented Dec 14, 2020

Fixed in #236.

@skozin skozin closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix reward distribution algorithm lidofinance/core
2 participants
@skozin @kadmil