Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for operator penalties / slashing cases #228

Closed
kadmil opened this issue Dec 5, 2020 · 4 comments
Closed

Tests for operator penalties / slashing cases #228

kadmil opened this issue Dec 5, 2020 · 4 comments
Assignees
Labels
question Further information is requested solidity issues/tasks related to smart contract code tests When it comes to testing the code

Comments

@kadmil
Copy link
Contributor

kadmil commented Dec 5, 2020

We want to have automated test scenarios for cases where some Node Operators get penalties and/or slashed and subsequently stopped by the DAO.

@kadmil kadmil self-assigned this Dec 5, 2020
@ongrid
Copy link
Contributor

ongrid commented Dec 5, 2020

This is possible as one of the branches of hierarchically-organized tests I mentioned in #224 Need to decide should we proceed with this

@ongrid ongrid added question Further information is requested solidity issues/tasks related to smart contract code tests When it comes to testing the code labels Dec 5, 2020
@ongrid
Copy link
Contributor

ongrid commented Dec 7, 2020

BTW Vlad Kuchinsky reported that he observes unexpected behavior of node operators reward addresses balances in the case of penalties. After the oracles report decreased numbers, the stETH balances of node operators reward addresses grow instead of decrease. I wasn't able to reproduce this within e2e. In my environment the behavior meets expectations.

### BEFORE REPORT
Now 10:05:53.327753
Current frame: [7560, 1607324733, 1607324892]
Total Pooled Ethers: 94.162715085888 
BufferedEther: 27.0
Nop0 Addr:0x27E9727FD9b8CdDdd0854F56712AD9DF647FaB74 stETH:0.6415011828062892
Nop1 Addr:0x9766D2e7FFde358AD0A40BB87c4B88D9FAC3F4dd stETH:1.2830023656125784
Epoch: 7560
depositedValidators: 3
beaconValidators: 3
beaconBalance: 67.162715085888
totalPooledEther: 94.162715085888

## AFTER REPORT with 10% decrease
Now 10:07:03.183769
Current frame: [7560, 1607324733, 1607324892]
Total Pooled Ethers: 87.4464435772992 
BufferedEther: 27.0
Nop0 Addr:0x27E9727FD9b8CdDdd0854F56712AD9DF647FaB74 stETH:0.5957453216580839
Nop1 Addr:0x9766D2e7FFde358AD0A40BB87c4B88D9FAC3F4dd stETH:1.1914906433161678
Epoch: 7560
depositedValidators: 3
beaconValidators: 3
beaconBalance: 60.4464435772992
totalPooledEther: 87.4464435772992

I guess it's either some sort of misconfiguration of Vlad's environment or some processes (like deposits or reporting increased numbers) running in parallel.

@ongrid
Copy link
Contributor

ongrid commented Dec 8, 2020

Had a troubleshooting session with Vlad. Not reproduced in his e2e env with incremental (step-by-step) approach.

This business-logic should be extensively covered by tests.

@ongrid ongrid assigned lxzrv and unassigned kadmil Dec 8, 2020
@kadmil
Copy link
Contributor Author

kadmil commented Dec 15, 2020

Added scenario tests in pulls #225, #236 and #256. Current scenario covers penalties and slashings (stopped validators / node operators) cases

@kadmil kadmil closed this as completed Dec 15, 2020
tamtamchik pushed a commit that referenced this issue Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested solidity issues/tasks related to smart contract code tests When it comes to testing the code
Projects
None yet
Development

No branches or pull requests

3 participants