Respect disabled normalisation with maximum volume

[AER00]

I've noticed an issue with my CPU usage on a really low end device while playing music with maximum volume. When volume is equal to 1.0 and normalisation is disabled the first condition failed (as it should) and librespot didn't check whether the normalisation was disabled anymore - it just normalised the song anyway using self.config.normalisation_method.

[kingosticks]

This is a great catch.

[kingosticks]

Maybe nice to group the two non-normalised cases in one branch

                        if !self.config.normalisation {
                            if volume < 1.0 {
                                for sample in data.iter_mut() {
                                    *sample *= volume;
                                }
                            }
                        }     

[kingosticks]

Can you fix the formatting?

[roderickvd]

For reasons of style and saving one or two CPU instructions I propose to fold the branch like this:

if !self.config.normalisation {
  if volume < 0 {
      //
  }
} else if …

[AER00]

For reasons of style and saving one or two CPU instructions I propose to fold the branch like this:

if !self.config.normalisation {
  if volume < 0 {
      //
  }
} else if …

Have you seen the recent commit?

[roderickvd]

Ah very good, thanks!

[kingosticks]

LGTM.

I think we said we wouldn't backport anything more to master but... What do you say?

[roderickvd]

One final question @AER00: would you update the changelog?

@kingosticks I don't really consider it anymore for me to say. But to offer my advice, if anyone is going to cut a release, I would spend the time in cutting the 0.5.x release.

[kingosticks]

I'm just wondering if there's utility in cherry picking into master. I guess those that care already have their forks.

Thanks all for this good fix.