Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect disabled normalisation with maximum volume #1159

Merged
merged 3 commits into from
May 6, 2023
Merged

Respect disabled normalisation with maximum volume #1159

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c0cdbd
respect disabled normalisation with max volume
AER00 May 2, 2023
34530bd
group normalisation disabled in one branch and fix formatting
AER00 May 2, 2023
0cf95c8
normalisation fix - changelog
AER00 May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion playback/src/player.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,10 @@ impl PlayerInternal {
// dynamic method, there may still be peaks that we want to shave off.

// No matter the case we apply volume attenuation last if there is any.
if !self.config.normalisation && volume < 1.0 {
if !self.config.normalisation && volume >= 1.0 {
// do not alter sample
}
else if !self.config.normalisation && volume < 1.0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe nice to group the two non-normalised cases in one branch

                        if !self.config.normalisation {
                            if volume < 1.0 {
                                for sample in data.iter_mut() {
                                    *sample *= volume;
                                }
                            }
                        }

for sample in data.iter_mut() {
*sample *= volume;
}
Expand Down