Backport librespot-org#1159: don't normalize value when we're using f…

…ixed volume.
michaelherger · May 4, 2023 · 931b4e6 · 931b4e6
1 parent 71e54d4
commit 931b4e6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/playback/src/player.rs b/playback/src/player.rs
@@ -1323,9 +1323,11 @@ impl PlayerInternal {
                         // there is nothing to normalise (all samples should pass unaltered). For the
                         // dynamic method, there may still be peaks that we want to shave off.
                         // No matter the case we apply volume attenuation last if there is any.
-                        if !self.config.normalisation && volume < 1.0 {
-                            for sample in data.iter_mut() {
-                                *sample *= volume;
+                        if !self.config.normalisation {
+                            if volume < 1.0 {
+                                for sample in data.iter_mut() {
+                                    *sample *= volume;
+                                }
                             }
                         } else if self.config.normalisation_method == NormalisationMethod::Basic
                             && (normalisation_factor < 1.0 || volume < 1.0)