Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design new identify protocols #443

Closed
tomaka opened this issue Aug 31, 2018 · 1 comment
Closed

Design new identify protocols #443

tomaka opened this issue Aug 31, 2018 · 1 comment

Comments

@tomaka
Copy link
Member

tomaka commented Aug 31, 2018

The current identify protocol is not great, so let's design new ones.

I think we need three protocols:

  • One that only reports the observed address, for NAT traversal.
  • One that reports information about the node, including its name. That could be done in a generic way, in other words fields wouldn't be hard-coded.
  • One that only reports the public key of the node.

All that is needed for each protocol is something similar to this: https://github.com/libp2p/rust-libp2p/blob/master/protocols/identify/src/protocol.rs
No need for new transports.

cc paritytech/substrate#398

twittner added a commit to twittner/rust-libp2p that referenced this issue Oct 15, 2018
twittner added a commit to twittner/rust-libp2p that referenced this issue Oct 15, 2018
twittner added a commit to twittner/rust-libp2p that referenced this issue Oct 17, 2018
twittner added a commit that referenced this issue Oct 28, 2018
Add protocol to report external address view.

Address part of #443.
@romanb
Copy link
Contributor

romanb commented Sep 5, 2019

Closing as a result of #1238.

@romanb romanb closed this as completed Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants