Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

libp2p/polkadot protocol handshake should include --name param #398

Closed
gavofyork opened this issue Jul 22, 2018 · 2 comments
Closed

libp2p/polkadot protocol handshake should include --name param #398

gavofyork opened this issue Jul 22, 2018 · 2 comments
Labels
J0-enhancement An additional feature request.
Milestone
Polkadot

Comments

@gavofyork
Copy link
Member

Nodes have a public name provided by --name parameter on the CLI. This should be (optionally) provided to any remote nodes during handshake to facilitate debugging in network logs.
@gavofyork gavofyork added the J0-enhancement An additional feature request. label Jul 22, 2018
@gavofyork gavofyork added this to the PoC-2 (Co-finalisation) milestone Jul 22, 2018
@tomaka
Copy link
Contributor

tomaka commented Jul 24, 2018

Libp2p has no way to do this right now, but the good thing with it is that we can invent our own protocol.

@gavofyork gavofyork removed this from the PoC-3 (AFG) milestone Aug 30, 2018
@tomaka tomaka mentioned this issue Aug 31, 2018
Closed
@gavofyork gavofyork added this to the 1.0 milestone Sep 5, 2018
@gavofyork gavofyork modified the milestones: 1.0 (final), 1.x series Dec 18, 2018
@gavofyork
Copy link
Member Author

over-dependent on the upstream protocol so will close for now.

liuchengxu pushed a commit to chainx-org/substrate that referenced this issue Aug 23, 2021
@koushiro
Improve some trivial things in bitcoin (paritytech#398)
16c2b1c 
Signed-off-by: koushiro <[email protected]>
liuchengxu pushed a commit to autonomys/substrate that referenced this issue Jun 3, 2022
@i1i1
Merge pull request paritytech#398 from subspace/farmer-readme-update
fc83a14 
Add wipe description to the farmer README
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request.
Projects
None yet
Milestone
Polkadot
Development

No branches or pull requests
2 participants
@gavofyork @tomaka