-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Silent failure of DockerAgent
's push_image()
, pull_image()
#2572
fix: Silent failure of DockerAgent
's push_image()
, pull_image()
#2572
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
DockerAgent.push_image()
38e91ed
to
5de8fef
Compare
5de8fef
to
d2492e5
Compare
f095d3a
to
d2e8827
Compare
In addition to modifying the |
2dafcb8
to
e6ca06b
Compare
DockerAgent.push_image()
DockerAgent
's push_image()
, pull_image()
In this PR, I found several incorrect return types in Until the above PR is merged, I’ll manually cast these types to |
0384696
to
d0a5159
Compare
d0a5159
to
cfd9bed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…#2572) Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 2572
…#2572) Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 2572
This PR modifies the behavior of the
DockerAgent
so that when an error occurs during the execution ofpush_image()
orpull_image()
, it does not fail silently but instead informs the user that an issue has occurred.Test
Tested manually.
For example, when incorrect Docker credentials are used, it will raise an error like below.
Checklist: (if applicable)