fix: Silent failure of DockerAgent.push_image

lablup · Jul 26, 2024 · 38e91ed · 38e91ed
1 parent 859b09d
commit 38e91ed
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/ai/backend/agent/docker/agent.py b/src/ai/backend/agent/docker/agent.py
@@ -1343,7 +1343,13 @@ async def push_image(self, image_ref: ImageRef, registry_conf: ImageRegistry) ->
             }
 
         async with closing_async(Docker()) as docker:
-            await docker.images.push(image_ref.canonical, auth=auth_config)
+            result = await docker.images.push(image_ref.canonical, auth=auth_config)
+
+            # Why is this list? It contradicts the API documentation.
+            result_ = cast(list, result)
+
+            if error := result_[-1].get("error"):
+                raise RuntimeError(f"Failed to push image: {error}")
 
     async def pull_image(self, image_ref: ImageRef, registry_conf: ImageRegistry) -> None:
         auth_config = None

diff --git a/src/ai/backend/common/bgtask.py b/src/ai/backend/common/bgtask.py
@@ -167,7 +167,11 @@ async def push_bgtask_events(
                             else:
                                 await resp.send("{}", event="bgtask_done")
                             await resp.send("{}", event="server_close")
-                        case BgtaskCancelledEvent() | BgtaskFailedEvent():
+                        case BgtaskCancelledEvent():
+                            await resp.send("{}", event="bgtask_failed")
+                            await resp.send("{}", event="server_close")
+                        case BgtaskFailedEvent():
+                            await resp.send("{}", event="bgtask_cancelled")
                             await resp.send("{}", event="server_close")
             except:
                 log.exception("")