fix: Silent failure of DockerAgent's push_image(), pull_image()

changes/2572.fix.md

@@ -0,0 +1 @@
+Fix silent failure of `DockerAgent.push_image()`, `DockerAgent.pull_image()`.

src/ai/backend/agent/docker/agent.py

@@ -1487,7 +1487,13 @@ async def push_image(self, image_ref: ImageRef, registry_conf: ImageRegistry) ->
             }
 
         async with closing_async(Docker()) as docker:
-            await docker.images.push(image_ref.canonical, auth=auth_config)
+            # TODO: Remove this useless type casting after resolving https://github.com/aio-libs/aiodocker/pull/909.
+            result = cast(list, await docker.images.push(image_ref.canonical, auth=auth_config))
+
+            if not result:
+                raise RuntimeError("Failed to push image: unknown error")
+            elif error := result[-1].get("error"):
+                raise RuntimeError(f"Failed to push image: {error}")
 
     async def pull_image(
         self,
@@ -1508,7 +1514,16 @@ async def pull_image(
             }
         log.info("pulling image {} from registry", image_ref.canonical)
         async with closing_async(Docker()) as docker:
-            await docker.images.pull(image_ref.canonical, auth=auth_config, timeout=timeout)
+            # TODO: Remove this useless type casting after resolving https://github.com/aio-libs/aiodocker/pull/909.
+            result = cast(
+                list,
+                await docker.images.pull(image_ref.canonical, auth=auth_config, timeout=timeout),
+            )
+
+            if not result:
+                raise RuntimeError("Failed to pull image: unknown error")
+            elif error := result[-1].get("error"):
+                raise RuntimeError(f"Failed to pull image: {error}")
 
     async def check_image(
         self, image_ref: ImageRef, image_id: str, auto_pull: AutoPullBehavior